search

DamonOehlman / travis-multirunner

A simple configuration for running (limited) multibrowser tests on travis ci
8 stars 14 forks source link

Fixes positional arguments for all environments #10

Closed nathanoehlman closed 9 years ago

nathanoehlman commented 9 years ago

The launch function in start was causing all sorts of problems with the passing through of positional arguments - worked fine on Mac, failed horribly on Linux and Travis CI and caused all sorts of issues.

After trying various permutations trying to make the function work, it has now been relegated to the scrap heap...

DamonOehlman commented 9 years ago

Looks good Nathan, one question was that +extension RANDR opt for xvfb required to get tests passing and thus should we document it somewhere?

nathanoehlman commented 9 years ago

Yeah - that's unnecessary. That was my attempt to remove the Xlib: extension "RANDR" missing on display ":99.0". warnings that kept appearing - they still appear, so it doesn't fix anything, and the warning doesn't cause any problems apart from just messing up the logs, so I think I'll remove that bit.

DamonOehlman commented 9 years ago

Ah, that makes sense - good idea, shame it didn't do something as I'm not a massive fan of that warning message either...

DamonOehlman commented 9 years ago

Published as 2.7.2

nathanoehlman commented 9 years ago

Awesome - thanks :)