search

DamonOehlman / travis-multirunner

A simple configuration for running (limited) multibrowser tests on travis ci
8 stars 14 forks source link

Add Safari support #23

Closed aullman closed 7 years ago

aullman commented 7 years ago

Adds support for Safari. You can use Safari Technology Preview with BROWSER=safari BVER=unstable and stable with BROWSER=safari BVER=stable. Stable will just use the default version of Safari that is installed with Mac OS 10.12. Unstable will download Safari Technology Preview which now supports WebRTC. The start-safari.sh command turns on fake devices, allows insecure domains and allows devices access on localhost.

We should probably add the Safari download URL to the browsers.contralis.info service. Right now it's scraping from the Safari Tech Preview download site which is brittle.

DamonOehlman commented 7 years ago

@aullman woot, I was keeping an eye on this one :)

I'll merge the PR and bump the MAJOR version so it's very clearly an opt-in. Have also added yourself, @fippo and @nathanoehlman as collaborators on this repo.

Adam - to that effect once I've created the new git tag for 4.0.0 would you be so kind as to draw up some simple release notes please? Maybe highlighting the changes that you needed to make to the matrix settings in travis.yml to ensure the correct machine types were selected.

@nathanoehlman What needs to be done WRT browsers.contralis.info ??

DamonOehlman commented 7 years ago

@aullman PR in and 4.0.0 published. Below is the link for creating new release notes ;)

https://github.com/DamonOehlman/travis-multirunner/releases/new?tag=v4.0.0

fippo commented 7 years ago

i would have slightly preferred "TechnologyPreview" as BVER but... yay, thanks Adam!

@youennf is there any recommended URL to download STP automatically?

aullman commented 7 years ago

Created :) Let me know if you think I should add any more details.

aullman commented 7 years ago

@fippo yeah, good point. I wasn't sure whether to stick with the existing "stable" "unstable" nomenclature. I was also thinking you could call STP "beta".

fippo commented 7 years ago

calling it TechnologyPreview avoids that nomenclature problem ;-)

fippo commented 7 years ago

https://github.com/webrtc/adapter/pull/593 failed because remote automation is not enabled. Does this need to write another setting and do a sudo safaridriver as suggested here?

fippo commented 7 years ago

defaults write com.apple.Safari IncludeDevelopMenu -bool true should do the trick according to stackoverflow

oh wait. that person is asking that question ...

fippo commented 7 years ago 
defaults write com.apple.safari ApplePersistenceIgnoreState YES

should this be tech preview as well?

I also just noticed the permissions plist trick. Neat!

aullman commented 7 years ago

@fippo yes, good catch, that should be SafariTechnologyPreview as well. I'm not sure what to do about the automation setting for WebDriver. I hadn't tested that yet and it doesn't look like it's straight forward to turn on anymore. I'll look into it.

aullman commented 7 years ago

@youennf do you know how to turn on the "Allow Remote Automation" option programatically?

fippo commented 7 years ago

@burg might be able to help -- or listen to "we need this"