search

DamonOehlman / travis-multirunner

A simple configuration for running (limited) multibrowser tests on travis ci
8 stars 14 forks source link

setup: ignore electron, nw and android #38

Closed fippo closed 6 years ago

fippo commented 6 years ago

adds the option to install electron via npm

fippo commented 6 years ago

Not sure if this behaviour makes sense. Maybe ignore it alltogether and make it the users problem?

I already do another npm install for the launcher in https://github.com/webrtc/adapter/pull/763 but that failed because setup.sh broke.

fippo commented 6 years ago

went a different way and decided to ignore stuff we don't support like android (as browser version), electron and nw

aullman commented 6 years ago

LGTM, we used "electron" with a lower case E and "edge" with a lower case E.

fippo commented 6 years ago

hrm... karma-electron-launcher uses Electron so i went for that. I wonder about a whitelist instead of a blacklist... :-)

fippo commented 6 years ago

published as 4.4.0