search

DamonOehlman / travis-multirunner

A simple configuration for running (limited) multibrowser tests on travis ci
8 stars 14 forks source link

Replace browsers.contralis.info #42

Closed nathanoehlman closed 6 years ago

nathanoehlman commented 6 years ago

Addresses #34.

This replaces http://browsers.contralis.info with https://browser-version-api.herokuapp.com - same service as it's always been, just with 100% less potential for DNS failure (assuming of course that Heroku is better at paying renewals).

DamonOehlman commented 6 years ago

LGTM - @fippo @aullman LGTY?

@nathanoehlman Would you be able to create a repository for this herokuapp in the instance that people do want to deploy there own instance? Seems like a reasonable request and I can't imagine there'd be anything in there that you didn't want to share, apart from cleaning up the code a little ;)

nathanoehlman commented 6 years ago

Nope - no problems at all. The repository does already exists at https://github.com/nathanoehlman/browser-version-api - that's all there is to it :)

Just push using the CLI command line, and presto. The only other thing I do is that because the Heroku free dynos shut down in the absence of traffic, I have a nodeping check that runs that keeps it alive to ensure there's no load up time when it gets hit.

fippo commented 6 years ago

LGTM -- but i'd still like to just replace it with a local browsersleuth call. Less dependencies :-)

But this can fly as a a patch version in the meantime

aullman commented 6 years ago

LGTM too, I like the idea of allowing people to host their own service too. Perhaps we could allow the URL to be an environment variable if people want to swap it out.

fippo commented 6 years ago

published as 4.4.1 -- many thanks!

DamonOehlman commented 6 years ago

@fippo Thanks, and I agree we should definitely continue discussing whether going with a local browsersleuth installation will just simplify things in #41.