search

DamonOehlman / travis-multirunner

A simple configuration for running (limited) multibrowser tests on travis ci
8 stars 14 forks source link

setup: add lots of quotes everywhere #43

Closed fippo closed 1 year ago

fippo commented 6 years ago

in all places where there should be quotes

fippo commented 6 years ago

@aullman do you have an idea why this fails in safari unstable? I suspect its because the "unsafe" curl/sed combo no longer works but don't have a mac to verify

fippo commented 6 years ago

@aullman it seems we need to update the osx base image and there are now issues with soundflower?!

Shall I split the "add quotes" from those commits and merge despite STP failing?

aullman commented 6 years ago

Sorry for the late response.

Yes, there is an issue now where Safari tech preview requires Mac OS 10.12 now and you can’t install soundflower on it programmatically anymore. Which means you run into a bug where Safari crashes when you call getUserMedia because of this bug https://bugs.webkit.org/show_bug.cgi?id=172794

Not sure how long before that bug is fixed and I couldn’t find a way to install soundflower. There might be another way to get audio output on Travis? Not sure.

For now yeah, I would make STP and allowed failure and merge this in.

fippo commented 6 years ago

so setup.sh needs a small version bump but then soundflower crashes. Going to ignore the STP failure for this PR

fippo commented 1 year ago

works fine without quotes. Don't quote me ;-)