search

Damonlee92 / Build_Your_Own_AI_Investor_2021

AI Investor
https://www.valueinvestingai.com
GNU General Public License v3.0
40 stars 42 forks source link

Error in Chapter 4 to 6/ 2 Process X_Y Learning Data in the last paragraph #2

Open Markuswalz opened 3 years ago

Markuswalz commented 3 years ago

Hi there,

I am really enjoying your book unfortunately there is a mistake in the last paragraph in X[Net Income] = X[Net Income_x] line 22.

And also one in the first of the section (filtering raw data) in line 51 and X has to be x or x in def getYPricesReportDateAndTargetDate(x, d, modifier=365) has to be X

Damonlee92 commented 3 years ago

Hi,

I've fixed the latter issue, going to check the first issue.

Thanks very much for posting, glad you are enjoying the book.

Markuswalz commented 3 years ago

Hi there, any solution so far? Would be great if you could help me out.

Best regards

Markus

Damonlee92 commented 3 years ago

For the first issue, it seems SimFin changed their column names since I last made the code? I'll remove that line as there doesn't seem to be a "Net Income_x" column any more.