search

Dan-in-CA / sip_plugins

Plugins for SIP
28 stars 49 forks source link

Flow plugin - initial submission #54

Closed IMHarris closed 2 years ago

IMHarris commented 2 years ago

Hi Dan,

First time contributing to a GitHub project, so I hope I'm doing this correctly. Here's the flow addin. I think version 1 is ready to go.

Documentation is here.

Happy to answer any questions.

Regards,

Ian

Dan-in-CA commented 2 years ago

Thanks Ian, Your contribution is greatly appreciated. It looks like your pull request can be merged without any problems. I will look it over first and then merge it shortly. Dan

Dan-in-CA commented 2 years ago

The only other thing that needs to happen is to add the name and description of your plugin to the README.md file on the plugins repo so it will show up for selection in the Plugin manager. I will take care of that. Dan

Dan-in-CA commented 2 years ago

There was a problem installing the plugin. The flowhelpers folder does not get created by the plugin manager, This causes an error. I will work on a fix. It may take a couple of hours. Dan

Dan-in-CA commented 2 years ago

I created the flowhelpers folder manually and got the plugin to install. When SIP restarted there was a divide by zero error raised. I'm not sure how serous the error is because the plugin seems to load and run. It may have something to do with the fact that I don't have a sensor installed?

Don't worry we will get thing sorted out.

IMHarris commented 2 years ago

Thanks for helping get all this sorted out. I have a hunch where the /0 is coming from. Looking at it now.

Dan-in-CA commented 2 years ago

By the way You did a great job with the docs. One suggestion: It might be a good idea to mention under requirements that I2C must be enabled on the Pi.

A contributor in the Netherlands has created a really cool SIP install script that offers to enable I2C during set up. It is still being tested but will be available soon.

I looked for a way to download a folder from GitHub but it looks like the best way to go is to put flowhelpers.py and maybe arduinocode.txt into the SIP/plugins folder. Alternatively, you could place arduinocode.txt in the docs wiki and users could get it from there which would probably be easier for them. I tried putting flowhelpers.py in the plugins folder and commented out line 7 of flow.py and it seemed to work OK. This will also require minor edits to the manifest file.

Let me know what you find about the divide by zero problem.