search

Dan6erbond / sk-auth

Authentication library for use with SvelteKit featuring built-in OAuth providers and zero restriction customization!
MIT License
578 stars 70 forks source link

✨ add github provider #50

Closed Odonno closed 2 years ago

Odonno commented 2 years ago

I needed this provider so I created first on my project and then sharing it to other with this PR. I tested it and it works fine.

Also note that there is a lot of data retrieved from GitHub profile, I only put the most interesting properties. We could check the GitHub API documentation to complete the GitHubProfile type.

Dan6erbond commented 2 years ago

Great addition! GitHub will be a common provider for many dev-oriented projects. I suppose we might need to extend it to be possible to configure which fields to request, as I believe GitHub supports GraphQL or some form of requesting fields.

TODO. Will merge the current changes for now.