search

Dan6erbond / sk-auth

Authentication library for use with SvelteKit featuring built-in OAuth providers and zero restriction customization!
MIT License
578 stars 70 forks source link

🎨 Fix prettier and eslint errors #57

Closed lulzneko closed 2 years ago

lulzneko commented 2 years ago

Fix the errors reported by prettier and eslint

README.md

prettier will report an error if there is a _ in the middle of a sentence surrounded by . If the `and*` are interchanged, prettier will format them as in the current source. And it will get an error. The only way to achieve italicized display was with HTML tags.

app/src/routes/profile.svelte

ESLint will report '$session' is not defined no-undef error. Strangely enough, inserting <script></script> does not report any error. https://github.com/sveltejs/eslint-plugin-svelte3/issues/107#issuecomment-820747718

package.json

The installation of eslint-plugin-svelte3 was missing

Dan6erbond commented 2 years ago

Good info. Didn't notice the Prettier plugin was missing, but the README.md might have to be ignored from its config to avoid those issues. HTML makes markup too convoluted IMHO.

Dan6erbond commented 2 years ago

I went over these issues again and fixed them in #60 so thanks for the contribution and I'll close this PR now!