Dan6erbond / sk-auth

Authentication library for use with SvelteKit featuring built-in OAuth providers and zero restriction customization!
MIT License
578 stars 70 forks source link

feat: spotify provider #60

Closed alexstaroselsky closed 2 years ago

alexstaroselsky commented 2 years ago

Add provider for Spotify

alexstaroselsky commented 2 years ago

Supporting documentation:

Dan6erbond commented 2 years ago

Nice! Simple enough to work with, look forward to playing around with it.

alexstaroselsky commented 2 years ago

Prettier linting was failing around syntax in README.md and prettier format was causing markdown to loss emphasis for that block. Update syntax of the block related to VITE_ environment variables to pass lint while maintaining emphasis.

alexstaroselsky commented 2 years ago

Maybe README.md can be added to prettier ignore? Format does some interesting things to the README. Changes:

***Warning**: env variables prefixed with `VITE_` can be exposed and leaked into client-side bundles if they are referenced in any client-side code. Make sure this is not the case, or consider using an alternative method such as loading them via dotenv directly instead.*

to

**\*Warning**: env variables prefixed with `VITE_` can be exposed and leaked into client-side bundles if they are referenced in any client-side code. Make sure this is not the case, or consider using an alternative method such as loading them via dotenv directly instead.\*

Similar thing was happening with the existing version of README.md for this block, the adding of the \ character.

Dan6erbond commented 2 years ago

Nice! Merged.

Maybe README.md can be added to prettier ignore? Format does some interesting things to the README. Changes:

***Warning**: env variables prefixed with `VITE_` can be exposed and leaked into client-side bundles if they are referenced in any client-side code. Make sure this is not the case, or consider using an alternative method such as loading them via dotenv directly instead.*

to

**\*Warning**: env variables prefixed with `VITE_` can be exposed and leaked into client-side bundles if they are referenced in any client-side code. Make sure this is not the case, or consider using an alternative method such as loading them via dotenv directly instead.\*

Similar thing was happening with the existing version of README.md for this block, the adding of the \ character.

Just added README.md to the .prettierignore to deal with this issue! Thanks for pointing it out.