search

Dan6erbond / sk-auth

Authentication library for use with SvelteKit featuring built-in OAuth providers and zero restriction customization!
MIT License
581 stars 70 forks source link

Missing copyright information in license? #88

Closed vhscom closed 2 years ago

vhscom commented 2 years ago

I noticed in the history of this repo some code is copied from Cheeri-No: https://github.com/Dan6erbond/sk-auth/commit/d7c4438f43e17b22afbcae9ca5efbea13fb7d383

And I saw in Cherri-No some code may have been copied from NestJS MikroORM template: https://github.com/Dan6erbond/Cheeri-No/commit/705a9bbcbcc70f1c9c29d9b7f606c8c1617c6020

I found the following repos related to NestJS MikroORM but not any auth code: https://github.com/mikro-orm/nestjs Copyright (c) 2019 Dario Mancuso, Martin Adámek

Though I did find at least some parts of the code copied here: https://github.com/nestjs/nest/blob/99ee3fd99341bcddfa408d1604050a9571b19bc9/sample/19-auth-jwt/src/auth/auth.service.ts Copyright (c) 2017-2022 Kamil Mysliwiec https://kamilmysliwiec.com

The above use MIT licenses with copyright lines which should be included in the license of this repo if there was code which was copied in. For the sake of completeness, would you mind reviewing the sources of the code in this auth library and adding the necessary copyright lines to the LICENSE file? At current it looks like Kamil's copyright notice should be in there but I'm not sure.

Thank you!

Dan6erbond commented 2 years ago

Hey, thanks for creating this issue. I'd have to look at this in detail myself, as it's been a while since I created both codebases for Cheeri-No and SK-Auth, but the NestJS MikroORM template was created by myself under Jenyus-Org/nestjs-auth-graphql-mikroorm-starter.

It is simply a starter template combining MikroORM, NestJS and some other components used by the Cheeri-No backend, which SK-Auth doesn't use.

SK-Auth is strictly based on SvelteKit and other libraries used by it. Thus, the copyright doesn't apply to code within SK-Auth's repository, which only transferred the prototype of the auth framework that I created in Cheeri-No early on.

vhscom commented 2 years ago

Thank you. To summarize Cheeri-No combined code from MikroORM and NestJS. And although some code from Cheeri-No was copied into SK-Auth that code has since been purged from the codebase or was not under existing copyright. Is that an accurate summary?