search

Dan6erbond / sk-auth

Authentication library for use with SvelteKit featuring built-in OAuth providers and zero restriction customization!
MIT License
578 stars 70 forks source link

signIn/signOut broken due to SvelteKit update #99

Closed leovoon closed 2 years ago

leovoon commented 2 years ago

Recent sveltekit updates break endpoints https://github.com/sveltejs/kit/blob/master/packages/kit/CHANGELOG.md

leovoon commented 2 years ago

100 A pull request is opened to fix the issue.

caiges commented 2 years ago

@leovoon is signout working against these new changes? I'm using the main branch of sk-auth and seeing HTTP 405 on POST http://localhost:3000/api/auth/signout and an accompanying error:

Uncaught (in promise) SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data

I'll have to take a deeper look myself.

leovoon commented 2 years ago

@leovoon is signout working against these new changes? I'm using the main branch of sk-auth and seeing HTTP 405 on POST http://localhost:3000/api/auth/signout and an accompanying error:

Uncaught (in promise) SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data

I'll have to take a deeper look myself.

I have no issues with it. As the PR has been merged, I might as well close this issue. You may open one of your own.

caiges commented 2 years ago

I had aliased get and post imports from SvelteKitAuth due to changes in SvelteKit which were addressed with the merge. 🥂 thanks for that fix.