search

DanBloomberg / leptonica

Leptonica is an open source library containing software that is broadly useful for image processing and image analysis applications. The official github repository for Leptonica is: danbloomberg/leptonica. See leptonica.org for more documentation.
Other
1.79k stars 392 forks source link

FYI: Leptonica binary package in Debian and Ubuntu #594

Closed amitdo closed 2 years ago

amitdo commented 3 years ago

Dan,

On Debian and Ubuntu Leptonica is stuck in version 1.79.

FYI

amitdo commented 3 years ago

https://packages.debian.org/search?keywords=leptonica

https://packages.ubuntu.com/search?keywords=leptonica

DanBloomberg commented 3 years ago

@jbreiden

I recently did a 1.82 release. Can you make a debian package from it?

jbreiden commented 3 years ago

Hi Dan!

I miss you. Are you in Wyoming? Lays day hi some time. I need to do this and webp, I hope I can remember.

Jeff

On Mon, Oct 25, 2021, 11:15 AM Dan Bloomberg @.***> wrote:

@jbreiden https://github.com/jbreiden

I recently did a 1.82 release. Can you make a debian package from it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DanBloomberg/leptonica/issues/594#issuecomment-951180610, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF3NJUVJA6IH45ZIWTRGWDUIWNEJANCNFSM5GVUY7JA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

DanBloomberg commented 3 years ago

Thanks, Jeff. I'm back in CA, and would love to come by for a visit. Let me know if you need any info, and if you'll be home Halloween day, or after?

Dan

On Tue, Oct 26, 2021 at 7:44 PM jbreiden @.***> wrote:

Hi Dan!

I miss you. Are you in Wyoming? Lays day hi some time. I need to do this and webp, I hope I can remember.

Jeff

On Mon, Oct 25, 2021, 11:15 AM Dan Bloomberg @.***> wrote:

@jbreiden https://github.com/jbreiden

I recently did a 1.82 release. Can you make a debian package from it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/DanBloomberg/leptonica/issues/594#issuecomment-951180610 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABF3NJUVJA6IH45ZIWTRGWDUIWNEJANCNFSM5GVUY7JA

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/DanBloomberg/leptonica/issues/594#issuecomment-952488192, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD7KMLEKG727BO2VTOIU6YDUI5RP5ANCNFSM5GVUY7JA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

amitdo commented 2 years ago

Pinging @jbreiden

Any progress?

amitdo commented 2 years ago

@AlexanderP, maybe you can help with this task.

jbreiden commented 2 years ago

It's been in the back of my mind for a long time, and I'm still trying to summon the energy.

On Tue, Nov 30, 2021 at 5:16 AM Amit D. @.***> wrote:

@AlexanderP https://github.com/AlexanderP, maybe you can help with this task.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DanBloomberg/leptonica/issues/594#issuecomment-982626544, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF3NJVX3PZNUXMPIM4KQMTUOTFC3ANCNFSM5GVUY7JA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

amitdo commented 2 years ago

BTW, we finally released Tesseract 5.0.0 yesterday.

jbreiden commented 2 years ago

Leptonica 1.82 has been uploaded to Debian, it should show up on the tracking webpage within 24 hours.. Suggest keeping an eye on this, to see and testing if Tesseract Debian package will need a recompile and re-upload due to any accidental ABI compatibility issues.

https://tracker.debian.org/pkg/leptonlib

On Thu, Dec 2, 2021 at 1:51 PM Amit D. @.***> wrote:

Closed #594 https://github.com/DanBloomberg/leptonica/issues/594.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DanBloomberg/leptonica/issues/594#event-5708698674, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF3NJT4IOWUV4I2GSHN74LUO7S7HANCNFSM5GVUY7JA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

amitdo commented 2 years ago

@jbreiden, thank you!

amitdo commented 2 years ago

Hi @jbreiden,

It is now in sid but didn't move to testing.

Can you fix the issues raised in https://tracker.debian.org/pkg/leptonlib ?

What's the process to make Leptonica 1.82 also available in Ubuntu 22.04 ?

DanBloomberg commented 2 years ago

@jbreiden

The two abi-compliance checker warnings are due README.html and version-notes.html grabbing data from the Creative Commons web site.

The suggestion is to copy to a local source, with some caveats. Do you know how to do this properly?

jbreiden commented 2 years ago

That's interesting.

No release critical bugs have been filed against leptonica as far as I can tell. The main complaint appears to be a missing build for 32-bit Intel architectures. So far I'm not sure what would cause that.

There's also complaint related to multi-arch which I can probably do something about.

If I remember correctly, Ubuntu will pull from Debian unstable. So there is a good chance that even if we do nothing, this will be part of the next Ubuntu release. That said, we do want this to promote to testing.

I'm not currently near a relevant computer but should be tomorrow. Thank you for the heads up.

amitdo commented 2 years ago

The issue with the i386 build is a failed test.

///////////////   hash_reg   ///////////////
////////////////////////////////////////////////
leptonica-1.82.0 : libgif 5.1.9 : libjpeg 6b (libjpeg-turbo 2.1.2) : libpng 1.6.37 : libtiff 4.3.0 : zlib 1.2.11 : libwebp 0.6.1 : libopenjp2 2.4.0
Failure in hash_reg: value comparison for index 10
difference = 1.000000 but allowed delta = 0.000000
Failure in hash_reg: value comparison for index 14
difference = 1.000000 but allowed delta = 0.000000
Failure in hash_reg: value comparison for index 18
difference = 1.000000 but allowed delta = 0.000000
Failure in hash_reg: value comparison for index 22
difference = 1.000000 but allowed delta = 0.000000
Time:   2.179 sec
FAIL: hash_reg
amitdo commented 2 years ago

Fix flaky hash_reg test on i686

DanBloomberg commented 2 years ago

Correct: this was fixed on 14 Nov 2021.

Another simple fix to release 1.82.0 is to remove that test from prog/alltests_reg.c

jbreiden commented 2 years ago

I've uploaded Debian package 1.82.0-3 with the regression test fix, look for it tomorrow in the usual location.

https://tracker.debian.org/pkg/leptonlib

Dan, you are referring to one of the many complaints from Debian's lint system "lintian" complaining about a privacy violation. This is a very minor issue and not blocking anything. What's going on is the documentation, shipped with the package, includes an image from another website. The image is a Creative Commons logo. Which means Lawrence Lessig (or whoever has access to the logs from the Creative Commons website) could know when someone is reading the Leptonica documentation. To get rid of that warning, you would include the logo with Leptonica and link to it locally, instead of using the one from the Creative Commons website. I never bothered to mention this over the years because in the grand scheme of things, I think it is unimportant. You are welcome to address it if you wish.

Message ID: @.***>

DanBloomberg commented 2 years ago

Thanks, Jeff. Your patch should allow the i386 build to go forward.

I'm happy to let Creative Commons continue to handle their logo image :-)

jbreiden commented 2 years ago

I am not sure what broke.

amitdo commented 2 years ago

It looks better now, the BLOCKED warning disappeared.

Issues preventing migration: ∙ ∙ Too young, only 4 of 5 days old

Let's see if we'll move to testing tomorrow.

amitdo commented 2 years ago

https://tracker.debian.org/pkg/leptonlib

news

[2022-01-07] leptonlib 1.82.0-3 MIGRATED to testing (Debian testing watch)

@jbreiden, thanks again!

amitdo commented 2 years ago

Leptonica 1.82 is also available for Ubuntu Jammy 22.04: https://packages.ubuntu.com/jammy/libleptonica-dev

RobinFrcd commented 2 years ago

Hi all, leptonica is currently stuck on 1.79 on debian bullseye, the current stable release. Would it be possible to push the latest version for bullseye too ?

It's kind of a blocker to use tesseract 5 on debian: https://github.com/tesseract-ocr/tesseract/issues/3863

Thanks :pray:

DanBloomberg commented 2 years ago

@jbreiden

1.79 is from Jan 2020. What is the significance of it being 'stuck' on Debian with that release?

jbreiden commented 2 years ago

One web page says it got stuck due to a missing build on i386 architecture, but this page says all is well for i386. Getting stuck is bad, because it means the vast majority of people will not get the new version. I'm not sure at the moment what to do about it.

https://packages.qa.debian.org/l/leptonlib.html https://buildd.debian.org/status/package.php?p=leptonlib

On Thu, Jul 7, 2022 at 11:54 AM Dan Bloomberg @.***> wrote:

@jbreiden https://github.com/jbreiden

1.79 is from Jan 2020. What is the significance of it being 'stuck' on Debian with that release?

— Reply to this email directly, view it on GitHub https://github.com/DanBloomberg/leptonica/issues/594#issuecomment-1178077750, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF3NJQNVVF6OSLYAQYHGVDVS4RU3ANCNFSM5GVUY7JA . You are receiving this because you were mentioned.Message ID: @.***>

amitdo commented 2 years ago

Everything is OK.

1.82.0-2 was BLOCKED

Later version had no issues: 1.82.0-3 MIGRATED to testing

Ubuntu 22.04 was able to pick 1.82.

@RobinFrcd is talking about something else. He wants 1.82 to be backported to Debian stable.

amitdo commented 2 years ago

Half off-topic: @jbreiden, any chance for moving Tesseract from 4.1 to 5.2 in Debian?

https://github.com/tesseract-ocr/tesseract/issues/3673#issuecomment-1048203258

stweil commented 2 years ago

For Debian bullseye it would be be better to simply apply commit 480f5e74c24fdc2003c42a4e15d1f24c9e6ea469 to get a fix for the FP exception.

jbreiden commented 2 years ago

Debian has two different tracking sites, and they disagree with each other. I think one is just broken and stale. Looking at the functioning one, both Leptonica and Tesseract have modern versions in Debian Testing, which is what we want. Other Debian colleagues have helped in this, and I think overall things are in relatively good shape.

https://tracker.debian.org/pkg/tesseract

RobinFrcd commented 2 years ago

Hi, I'm not sure that I understood. Tesseract is still on 4.0 for buster and 4.1 for bullseye.

jbreiden commented 2 years ago

You are correct, Tesseract is still on 4.0 for buster https://packages.debian.org/fr/buster/tesseract-ocr [a.k.a. Debian 10] and 4.1 for bullseye https://packages.debian.org/fr/bullseye/tesseract-ocr [a.k.a Debian 11]. And it will remain that way forever; that is how Debian works.

Most importantly, Tesseract is at 5.1 in bookworm https://packages.debian.org/fr/bookworm/tesseract-ocr [a.k.a. the upcoming Debian 12 release] Which means the software releases are flowing as expected and nothing is jammed up.

Message ID: @.***>

amitdo commented 2 years ago

And it will remain that way forever; that is how Debian works.

In the Debian world, there is the backports repo as a way to introduce new versions of software. This is only relevant to the current Debian stable and not to the 'old stable'.

It's a problem for us that we still get a lot of issues reports from people using Tesseract 4.x.