search

DanBloomberg / leptonica

Leptonica is an open source library containing software that is broadly useful for image processing and image analysis applications. The official github repository for Leptonica is: danbloomberg/leptonica. See leptonica.org for more documentation.
Other
1.72k stars 384 forks source link

Leptonica 1.84 release schedule #721

Closed amitdo closed 6 months ago

amitdo commented 8 months ago

https://github.com/DanBloomberg/leptonica/issues/663#issuecomment-1789587445

Jeff will hopefully be able to work through the dependencies and build a Debian release in time for Ubuntu 24-04.

Dan, do you plan to release 1.84 soon?

DanBloomberg commented 8 months ago

I would like to do it this month (November). Do you have any concerns or suggestions?

amitdo commented 8 months ago

Do you have any concerns or suggestions?

No. I just wanted to know what's your plan.

amitdo commented 7 months ago

Dan, just a reminder, in case you forgot about your plan.

DanBloomberg commented 7 months ago

Thanks :-)

I was just thinking about it today. I'll try to do it tomorrow.

DanBloomberg commented 7 months ago

Thanks :-) Sigh. A bunch of stuff came up. New plan: 1.84.0 this weekend!

DanBloomberg commented 6 months ago

Finally done. 1.84.0 is released

DanBloomberg commented 6 months ago

had to delete it (screwed up)

DanBloomberg commented 6 months ago

should be ok now

stweil commented 6 months ago

The GitHub release is still missing. Should I create it based on the tagged release?

DanBloomberg commented 6 months ago

I had to delete it again. I forgot to commit some documentation changes (to README.html, version-notes.html) when I did the initial release.

So I committed them. But when I tried to release with the same tag 1.84.0, it keeps using the old source from before the last commit. Do I need to use a different tag, like 1.84.1?

stweil commented 6 months ago

Either tag 1.84.1, or delete the existing 1.84.0 and create a new 1.84.0 based on the latest commit (that's what I would suggest).

DanBloomberg commented 6 months ago

how to delete the 1.84.0 tag?

DanBloomberg commented 6 months ago

ok, I figured it out :-)

DanBloomberg commented 6 months ago

finally, I think 1.84.0 is now correct

stweil commented 6 months ago

Yes, it looks good. Merry Christmas!

DanBloomberg commented 6 months ago

And Merry Christmas and relaxing holidays to you.

DanBloomberg commented 6 months ago

Well, this is inconvenient. Look at the win64-cmake failure in jp2kio.c: :\a\leptonica\leptonica\src\jp2kio.c(938,5): error C2198: 'opj_stream_set_user_data': too few arguments for call [D:\a\leptonica\leptonica\build\src\leptonica.vcxproj]

Can we get rid of that compiler conditional from years back and always use the 3 arg call to opj_stream_set_user_data() ?

DanBloomberg commented 6 months ago

@stweil That conditional seems like a dangerous hack, anyway. And I think the 2 arg version was changed to a 3 arg version at least 6 years ago, maybe more.

stweil commented 6 months ago

Yes, I also think it's time to remove that old code. But that's not urgent and can even wait until next year. :-)

DanBloomberg commented 6 months ago

Good to know. It is rather funny that this just happened for the first time on the release master.

amitdo commented 6 months ago

Thanks Dan!

amitdo commented 6 months ago

Jeff will hopefully be able to work through the dependencies and build a Debian release in time for Ubuntu 24-04.

CC: @jbreiden

amitdo commented 6 months ago

https://www.omgubuntu.co.uk/2023/10/ubuntu-24-04-release-date-set-for-april-25-2024

amitdo commented 6 months ago

I had to delete it again. I forgot to commit some documentation changes (to README.html, version-notes.html) when I did the initial release.

Many projects document the release process including the files that need to be updated.

DanBloomberg commented 6 months ago

I haven't done it, but it seems like a good idea to list those files, and I'll do it in version-notes.html for the next release.

stweil commented 6 months ago

Good to know. It is rather funny that this just happened for the first time on the release master.

That was simply bad luck. The old code always failed with OpenJPEG versions x.y.0 because checking for OPJ_VERSION_MINOR == 0 always had been wrong (it should have checked the major version, too). So as soon as the build environment updated to OpenJPEG 2.5.0, it failed again (like it might have done for 2.1.0, 2.2.0, 2.3.0 and 2.4.0 in the past). It's good that this is fixed now.

amitdo commented 6 months ago

Right now, I don't see any progress going on in Debian:

https://tracker.debian.org/pkg/leptonlib

So unless things change within the next 3 weeks, Ubuntu 24.04 will stay with Leptonica 1.82.

DanBloomberg commented 6 months ago

I have discussed this with Jeff, and due to a confluence of obligations over the next few months, he will not have time to make a new Debian release of leptonica.

I don't think it's a big deal, and he will do the upgrade if/when things get sufficiently less hectic.