Add pnpm and php support, formatting comments

DanBot-Hosting / Pterodactyl-Eggs

Repository of all the Pterodactyl eggs and docker images we (DanBot Hosting) have created for use.

MIT License

48 stars 26 forks source link

Add pnpm and php support, formatting comments #9

Closed domin-mnd closed 2 years ago

domin-mnd commented 2 years ago

Faced an issue when yarn and pm2 isn't installed in DBH, these changes may be useless as pnpm won't be installed just like yarn and pm2, though it works on local docker.

djohts commented 2 years ago

i dont understand how did u format the comments as most of the are still on first column

domin-mnd commented 2 years ago

some had no spacing before the "#", it makes no difference but still. Kinda useless pr, but in theory it adds pnpm (tested)

vinc3nz commented 2 years ago

Isn't nginx now enabled and running by default under port 80? As this would need to be changed to A: The containers port and B: to not run by default. It is unnecessary to run when not used. Also there is no way to edit configs I think, as you can't edit files in /etc/* on ptero/docker. Correct me if i am wrong

Sliden101 commented 2 years ago

Bundling Nginx into aio doesnt seem like a very good idea + dbh has nginx server iirc

DEV-DIBSTER commented 2 years ago

I'm guessing this was then changed for the docker image. https://hub.docker.com/r/danbothosting/aio

DEV-DIBSTER commented 2 years ago

Unless you want the changes to directly show up here in this repository is what I'm assuming.