DanChianucci / Eagle2Kicad

Converts an Eagle 6.0+ .brd into a kicad .brd
MIT License
92 stars 30 forks source link

Quotes around EQUIPOT Names? #24

Closed abetusk closed 10 years ago

abetusk commented 10 years ago

The KiCAD documentation has quotes around EQUIPOT Na "net name" fields, whereas the output does not put quotes around the net name fields. Page 18 of the PDF documentation implies there is are quotes around the "net name" field.

I feel this is a place where the documentation is a bit ambiguous. Should there be quotes around these net names? Is it optional?

The relevant line are in Board/Board.py:

def writeEQUIPOT(self, outFile):
    """
    Writes the EQUIPOT Sections to the outFile

    Params:
        Outfile: the file to output to

    Postconditions:
        The section has been written to the outfile
    """
    for signal in self.signals:
        signame = signal
        num = self.signals.get(signame)
        outFile.write('$EQUIPOT\n')
        outFile.write('Na ' + num + ' ' + signame + '\n')
        outFile.write('St~\n')
        outFile.write('$EndEQUIPOT\n')
DanChianucci commented 10 years ago

I am not sure about this one. But from a first glance it looks like KiCad strips the quotes from the net name anyways. I would imagine that they are only useful for Net Names which have spaces in them.

A quick look at eagle shows that it doesn't allow spaces in net names. This means that it shouldn't be an issue when converting. I would run a test in Kicad and see if there is any difference between quoted net names and non-quoted net-names.

If the quoted net names work then I would go with the documentation and add them to the conversion script.