search

DanElbert / vt-middleware

Automatically exported from code.google.com/p/vt-middleware
0 stars 0 forks source link

vt-password: PasswordDictionaryRule's default "numberOfWords" value is silly #79

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The current default value is '1', which is (IMO) plain silly.  A much more 
sensible default would be max-int ... or maybe the length of the supplied 
password.

(A default that you always have to override to get sensible behaviour is not 
worth having.)

Original issue reported on code.google.com by crawley....@gmail.com on 9 Jul 2010 at 6:18

GoogleCodeExporter commented 8 years ago 
This is addressed in the patch for issue 80 - I changed the default to 4.  
(After looking at the code, I figured that my previous suggestions were equally 
wrong.)

Original comment by crawley....@gmail.com on 12 Jul 2010 at 12:38

GoogleCodeExporter commented 8 years ago 
I could be convinced that 4 is a better default than 1.
It's one of those properties where no default is a good substitute for 
understanding what it does.

Original comment by dfis...@gmail.com on 12 Jul 2010 at 1:03

GoogleCodeExporter commented 8 years ago 
Default word length has been set to 4.

Original comment by dfis...@gmail.com on 17 Sep 2010 at 7:18