vt-ldap: 4.0 refactoring review

[GoogleCodeExporter]

Items to review:
  * Should ldap operations be methods on LdapConnection or is the current executor pattern better?
  * Should the ldif and dsml classes be re-factored to use a Reader/Writer pattern?
  * The ldap connection is lazily initialized to allow configuration to be set in any order. Is there a better way to do this? See LdapConfig and LdapConnection.

Code required to perform a search:

LdapConfig lc = new LdapConfig("ldap://directory.vt.edu", "dc=vt,dc=edu");
LdapConnection conn = new LdapConnection(lc);
conn.open();
SearchOperation search = new SearchOperation(conn);
LdapResult result = search.execute(new SearchRequest(new 
SearchFilter("uupid=dfisher"))).getResult();
conn.close();

Original issue reported on code.google.com by dfis...@gmail.com on 27 Jan 2011 at 3:02

[GoogleCodeExporter]

Begin code review.

Original comment by marvin.addison@gmail.com on 2 Feb 2011 at 8:42

• Changed state: Started

[GoogleCodeExporter]

Review changes to the props package:
http://code.google.com/p/vt-middleware/source/detail?r=1833

Original comment by dfis...@gmail.com on 22 Feb 2011 at 6:44

[GoogleCodeExporter]

Provided some line-by-line comments on the commit.  Why they're not showing up 
here by default is a mystery.

Original comment by marvin.addison@gmail.com on 22 Feb 2011 at 9:18

[GoogleCodeExporter]

This review has been completed.

Original comment by marvin.addison@gmail.com on 15 Jun 2011 at 4:48

• Changed state: Done