search

DanEngelbrecht / golongtail

Command line front end for longtail synchronization tool
MIT License
26 stars 8 forks source link

Network paths with spaces in them don't work #252

Closed eriknielsen closed 6 months ago

eriknielsen commented 7 months ago

Hi, I tried updating from 0.3.5 to 0.4.2 to get another bug fix but now it seems that if I do something like this .\longtail-0.4.2.exe get --source-path="\\networkdrive\Builds\Folder With Space\manifest.json" --target-path="destination\" I get level=fatal msg="get: ReadFromURI: fsBlobObject.Read: open \\\\networkdrive\\Builds\\Folder: The system cannot find the file specified.: file does not exist"

Seems like a bug?

DanEngelbrecht commented 7 months ago

For network paths you need to start with a double backslash

eriknielsen commented 7 months ago

No, that's not the issue, it must be the spaces in the path. I noticed now that the backslashes were removed from the original post

DanEngelbrecht commented 7 months ago

Ok, will have to investigate.

DanEngelbrecht commented 7 months ago

https://github.com/DanEngelbrecht/golongtail/pull/253

This means that paths with commas in them will have issues, but that is far less common.

eriknielsen commented 7 months ago

Oh nice! Yeah that works for me at least, I agree that comma is way less common.

eriknielsen commented 7 months ago

Is there a way I can test the Windows build out for the PR without building the branch myself?

DanEngelbrecht commented 6 months ago

Not currently no, working on a pre-release but want to test some things first

DanEngelbrecht commented 6 months ago

I think I will have to make a bigger change. It feels to limited to reserve , in file name.

DanEngelbrecht commented 6 months ago

Changed it to | . Normally not a usable character for filenames so should be less likely to conflict.

DanEngelbrecht commented 6 months ago

@eriknielsen Try https://github.com/DanEngelbrecht/golongtail/releases/tag/v0.4.3-pre0

eriknielsen commented 6 months ago

Verified that get and put work with network drive with spaces in the path, thank you very much!