license question

[IzzySoft]

I see your Xposed module uses GPLv3 – but I cannot find any license for the Magisk module. Did you just forget to add it? And do you offer a ready-to-use ZIP of the Magisk module as well (or does it suffice to zip up the repo content to get a proper module)?

[DanGLES3]

I see your Xposed module uses GPLv3 – but I cannot find any license for the Magisk module. Did you just forget to add it? And do you offer a ready-to-use ZIP of the Magisk module as well (or does it suffice to zip up the repo content to get a proper module)?

I personally see no need to add licenses to Magisk Modules

As for the zip, zipping the repo's content should ne enough, tho beware that GitHub's download as zip option will put the repo's content inside a folder on the zip

So you'll need to extract that folder and zip just the contents inside of it

[IzzySoft]

I personally see no need to add licenses to Magisk Modules

Does it hurt? It's code, and it's in the open. A license protects both sides. Without a license someone using the code can never be sure about "law suits coming" (or DMCA take-downs, or whatever) as no license essentially means "all rights reserved". And the other way around, you'd have some leverage if your code is being "abused". I'd just add the same license you're using for the Xposed module. Would then allow me to also provide it via my FOSS repo :wink:

As for the zip, zipping the repo's content should ne enough, tho beware that GitHub's download as zip option will put the repo's content inside a folder on the zip

Thanks for the first part, that would be achieved then by cloning the repo and zipping the contents instead of the "download as zip". Remaining question: where do those APKs in R and S (ExternalStorageProvider.apk) come from? I don't see corresponding code here in the repo (and yes, that's again a question of FOSS and licenses as well :wink:).

[DanGLES3]

I personally see no need to add licenses to Magisk Modules

Does it hurt? It's code, and it's in the open. A license protects both sides. Without a license someone using the code can never be sure about "law suits coming" (or DMCA take-downs, or whatever) as no license essentially means "all rights reserved". And the other way around, you'd have some leverage if your code is being "abused". I'd just add the same license you're using for the Xposed module. Would then allow me to also provide it via my FOSS repo 😉

As for the zip, zipping the repo's content should ne enough, tho beware that GitHub's download as zip option will put the repo's content inside a folder on the zip

Thanks for the first part, that would be achieved then by cloning the repo and zipping the contents instead of the "download as zip". Remaining question: where do those APKs in R and S (ExternalStorageProvider.apk) come from? I don't see corresponding code here in the repo (and yes, that's again a question of FOSS and licenses as well 😉).

As for the source code of said APKs, they were modded in smali code (instead of compiled from source), i could give you the changes I've made at a later date if you want (tho compiling the changes rather than doing them in smali would be much more preferable tho i have no experience compiling system apps)

As for the license, I'm personally not sure what license to apply to this module, as I've never really minded people using my work on third party modules or ROMs as that's kinda what I want (having ROMs without such restriction would be much more stable and preferable over an module)

Profit/fame after all has never really been my goal as it's a rather simple piece of work

[IzzySoft]

As for the source code of said APKs, they were modded in smali code

And their original code comes from where? Just for the records.

i could give you the changes I've made at a later date

Maybe include them with a public repo instead? And yes, of course compiling from source would be preferable – but as long as we can trace everything to FOSS, both should be OK.

As for the license, I'm personally not sure what license to apply to this module

I'd simply go with the same you used for the Xposed app. Keep it simple :wink: And I'd never say you're just after the money. Trouble is, it happens all the time – or how an US politician (Henry Kissinger) once put it: "90% of politicians give the other 10% a bad reputation." :see_no_evil: So unfortunately, one needs to be careful…