Code Review - Rhys Hudson

[Hxdsy]

After reviewing your project I have identified a number of issues:

• I originally had some issues with running your code, this may be due to issues on my side, but I think there may be problems within your project files, as upon copying the content of each c# file into a new project, the code managed to run.
• When your code prints the player's "Hand" or the "CardDeck" list to the user, it provides "CMP1903M_A01_2233.Card" instead of the properties of the object you are referencing. This can be fixed by providing the properties for the object that needs to be written, such as the suit and value of each card, instead of trying to print the object as a whole.
• When undergoing a Riffle shuffle, the player is not able to be dealt 3 or more cards, this however can be fixed by setting your dealt variable as type Class instead of var.
• Another issue is that you haven't used one the signatures within the brief (dealCard) to deal cards and the typeOfShuffle command requires 1, 2 and 3 to be used instead of 0, 1 and 2.
• If the user enters string instead of an integer to your "Input1" or "Input2" variables the code will create an error, so some error handling could be used to prevent this from occuring.
• You could also use a foreach command instead of counting down through your lists with a for command, just for efficiency.
• Some code comments are missing for certain areas of your code and documentation through a readme file could be used.

Here are some things that you have done well!

• Your algorithms for shuffling work relatively well and do not cause any issues.
• Your singular card deal has no issues and seems to work well.
• Your deck creation seems to work well, along with your get and set for the value and suit of each card!

Well done on creating your project!

[DanHumphreys395248]

That's a long list of problems. I was aware of one or two of these prior and will work on getting the problems with riffle shuffle, lists not showing card value/suit and error handling. Thank you for the review. it's bought to light a couple of things I didn't catch and will also work towards fixing. your comments are very insightful!