search

DanMcInerney / xsscrapy

XSS spider - 66/66 wavsep XSS detected
1.64k stars 438 forks source link

support for proxies? #29

Open SJCaldwell opened 8 years ago

SJCaldwell commented 8 years ago

I was wondering if it was planned to have support for proxies like Burp. For websites with complex authentication behavior, burp macros can end up being a reliable way to ensure a full scan is authenticated and makes it easier to do follow up tests once xss has been found.

If you'd be interested I'd be happy to try to add an optional command line argument specifying the proxy to go through.

DanMcInerney commented 8 years ago

That'd be great. Looks like you just need to add in the argument, then set HttpProxyMiddleware to point to the argument value. Alternatively, as this stack overflow link mentions, you can also just set the http_proxy environment variable before you run it. http://stackoverflow.com/questions/4710483/scrapy-and-proxies

SJCaldwell commented 8 years ago

Sounds good! I'll write that later this evening and hopefully send a pull request sometime this weekend.

SJCaldwell commented 8 years ago

It seems setting the environmental variable is the best route to get the middleware to work correctly.

If you don't provide a value to http_proxy, then nothing happens. So I guess all that's left to do is add it as a middleware in settings.py. If that sounds fine by you, I'll add it as 400 and make the pull request.