search

DanMcInerney / xsscrapy

XSS spider - 66/66 wavsep XSS detected
1.66k stars 441 forks source link

Switched to scrapy 1.1.0rc3 to fix SSL bug #31

Closed ddworken closed 8 years ago

ddworken commented 8 years ago

Scrapy prior to 1.1.0rc3 had an issue where it would fail to connect to certain servers with an error stating <twisted.python.failure.Failure OpenSSL.SSL.Error: ('SSL routines', 'SSL3_READ_BYTES', 'sslv3 alert handshake failure'), ('SSL routines', 'SSL3_WRITE_BYTES', 'ssl handshake failure')>. See https://github.com/scrapy/scrapy/issues/1764 for more info on this issue.

In that github issue, there were two potential solutions. Either add additional code forcing it to the correct code (see https://github.com/scrapy/scrapy/issues/1764#issuecomment-181950638). The other potential solution was upgrading to the latest release of scrapy.

There were pretty minimal changes needed to add support for 1.1.0rc3 (just changing import locations) so I went for that.

ddworken commented 8 years ago

Oops, after a little bit more testing I found a few weird edge cases. Closing for now while I track those down.

DanMcInerney commented 8 years ago

Thanks man!

On Oct 24, 2016 7:43 PM, "David Dworken" notifications@github.com wrote:

Oops, after a little bit more testing I found a few weird edge cases. Closing for now while I track those down.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DanMcInerney/xsscrapy/pull/31#issuecomment-255913347, or mute the thread https://github.com/notifications/unsubscribe-auth/ABuspSwISdmMiz5gwV9W3Sq-Hpo1nUFDks5q3V6jgaJpZM4Kfdow .