DanRuta / xVA-Synth

Machine learning based speech synthesis Electron app, with voices from specific characters from video games
GNU General Public License v3.0
590 stars 54 forks source link

Change editor selection behavior to more closely resemble windows behavior #39

Closed BartHageman closed 1 year ago

BartHageman commented 1 year ago

Hi, I decided to have a go at changing the editor's selection behavior to more closely resemble windows explorer and other programs. It was discussed a while ago in the discord suggestions'. (I'm Mobius#4304) message here

New behavior (with l being the selected letter):

I did also change the fact that Ctrl blocks adding a letter to your selection if you're dragging an unselected letter around, for consistency's sake.

This is my first open source pull request ever, so let me know if I dun goofed somewhere. 😁

DanRuta commented 1 year ago

Thank you for the pull request, sorry it took this long 😅

The changes look good, and I briefly played around with it on v2 and it seemed to work fine - if anything comes up I'll add a fix for it.