Machine learning based speech synthesis Electron app, with voices from specific characters from video games
GNU General Public License v3.0
590
stars
54
forks
source link
Wav2Vec2, FastPitch 1, and FastPitch 1.1 code does not remove '.exe' from expected executable paths when not running on Windows #71
Open
MightyAlex200 opened 5 months ago
In the following code locations, a '.exe' file path extension is expected independent of platform:
https://github.com/DanRuta/xVA-Synth/blob/72ac458ef794a7162b1205c39ec5fc9b7ff2007a/python/fastpitch/model.py#L103 https://github.com/DanRuta/xVA-Synth/blob/72ac458ef794a7162b1205c39ec5fc9b7ff2007a/python/fastpitch1_1/model.py#L200 https://github.com/DanRuta/xVA-Synth/blob/72ac458ef794a7162b1205c39ec5fc9b7ff2007a/python/wav2vec2/model.py#L33
Additionally, all code paths that check if the platform is Linux should be rewritten to check if the platform is NOT Windows: (for compatibility with macOS, BSD, etc.) https://github.com/DanRuta/xVA-Synth/blob/72ac458ef794a7162b1205c39ec5fc9b7ff2007a/python/xvapitch/text/ipa_to_xvaarpabet.py#L285 https://github.com/DanRuta/xVA-Synth/blob/72ac458ef794a7162b1205c39ec5fc9b7ff2007a/python/xvapitch/model.py#L179 https://github.com/DanRuta/xVA-Synth/blob/72ac458ef794a7162b1205c39ec5fc9b7ff2007a/python/xvapitch/model.py#L257 https://github.com/DanRuta/xVA-Synth/blob/72ac458ef794a7162b1205c39ec5fc9b7ff2007a/python/xvapitch/model.py#L389 https://github.com/DanRuta/xVA-Synth/blob/72ac458ef794a7162b1205c39ec5fc9b7ff2007a/python/xvapitch/model.py#L721 https://github.com/DanRuta/xVA-Synth/blob/72ac458ef794a7162b1205c39ec5fc9b7ff2007a/python/audio_post.py#L37 https://github.com/DanRuta/xVA-Synth/blob/72ac458ef794a7162b1205c39ec5fc9b7ff2007a/python/audio_post.py#L112 https://github.com/DanRuta/xVA-Synth/blob/72ac458ef794a7162b1205c39ec5fc9b7ff2007a/python/audio_post.py#L289