DanWBR / dwsim

DWSIM is a Steady-State and Dynamic Sequential Modular Chemical Process Simulator for Windows, Linux and macOS.
https://dwsim.org
GNU General Public License v3.0
285 stars 91 forks source link

[Bug] DWSIM.Thermodynamics\Assets\Databases\electrolyte.xml unit compiling #151

Closed JarlPed closed 3 years ago

JarlPed commented 3 years ago

IMPORTANT: This section is for code-related bugs. For usage issues, please go to the Support Forums.

Describe the bug When loading Electrolyte compounds, there's no difference between "Standard State Gibbs Energy of Formation at 298 K" and "Standard State Enthalpy of Formation at 298 K" when converting from KJ/mol to KJ/kg when compiling dwsim6\DWSIM.Thermodynamics\Assets\Databases\electrolyte.xml file. Perhaps this can be fixed by applying a conversion?

To Reproduce Steps to reproduce the behavior: Using SI units; Add for example "Sulfate (ion)" to the component list, and view the selected compound, browse to "[Electrolyte] Standard State Gibbs Energy of Formation at 298 K". View "DelGF_kJ_mol" for the compound with "Name" property "Sulfate (ion)" in file dwsim6\DWSIM.Thermodynamics\Assets\Databases\electrolyte.xm. The numbers are the same, but has different units.

Expected behavior I would have expected different numbers; e.g. for "Sulfate (ion)" where "[Electrolyte] Standard State Gibbs Energy of Formation at 298 K" == -7750,7 kJ/kg ; when considering -744.53 and 96.06 fields.

Screenshots If applicable, add screenshots to help explain your problem. image image

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

JarlPed commented 3 years ago

Update:

It appears that at least that Standard State Enthalpy of Formation is passed correctly to the reaction editing forms: image Is this bug only an issue for the compound viewer?

DanWBR commented 3 years ago

@JarlPed yes, the units in the compound viewer should have been hard-coded to kJ/mol, and not converted to the currently selected units.