search

DanWin / le-chat-php

A PHP Chat based on LE CHAT
https://danwin1210.de/chat/
GNU General Public License v3.0
268 stars 98 forks source link

Update README.md #144

Closed abhishek213-alb closed 10 months ago

abhishek213-alb commented 11 months ago

Improved readbility

rexzooly commented 11 months ago

You have removed caps where they should be this change already is incorrect when also PHP is the Correct way of doing it I don't find this change a improvement. you have also removed Caps from names this is also incorrect.

I do like the fact of the pointers but a lot of it you have incorrectly changed.

abhishek213-alb commented 11 months ago

@rexzooly let me modify once

abhishek213-alb commented 11 months ago

@rexzooly Mam please check once

rexzooly commented 11 months ago

Now you have caps where they shouldn't be like "Clone The", Clone was the start so it would be "Clone the"

I believe the original was fine as it was, I been using it on and off for years and never had a problem right now I am not sure why you made these changes, Also looking at the Read Me as it is the first part isn't meant to be in bullet points.

Why did you feel it didn't read correctly? I believe this merge myself is un-needed and in places incorrect.

DanWin commented 10 months ago

@abhishek213-alb Thanks for your contribution, but as discussed above, this is just incorrect change of capitalization. Thus I'm closing this pull request.