DanXi-Dev / DanXi-swift

A Swift Reimplementation of DanXi
GNU Affero General Public License v3.0
13 stars 3 forks source link

Floors containing images flash on load #76

Closed singularity-s0 closed 7 months ago

singularity-s0 commented 7 months ago

https://github.com/DanXi-Dev/DanXi-swift/assets/12184989/f2f21d11-d915-46e5-ae7e-0311ffdbeb99

singularity-s0 commented 7 months ago

This is due to images being re-rendered as the floor is updated with full data (as opposed to the incomplete prefetch data). The "fix" merely made it less visually impacting.

To fully resolve this issue, we need to either fine-grain floor view update so that unchanged content stays unchanged, or implement a memory-based image cache.

singularity-s0 commented 7 months ago

Memory-based image cache has been implemented in f8478197285be6f35d5124ec9b86512423fc44b4