search

DanXi-Dev / DanXi-swift

A Swift Reimplementation of DanXi
GNU Affero General Public License v3.0
13 stars 3 forks source link

[Enhancement] Better Navigation on Wide Screen #89

Closed fsy2001 closed 7 months ago

fsy2001 commented 7 months ago

Add support for 3-column navigation on wide screen devices like iPad and Mac.

This task is rather complicated, as navigation APIs in SwiftUI have a lot of limitations, so as UIKit.

Bugs to Fix

fsy2001 commented 7 months ago

This implementation has several bugs, including:

  1. Navigation links are not responsive in curriculum page, the reason is missing detail appending callback.
  2. Showing sheet in forum page will cause app screen to change, reason unknown. Reopening.
fsy2001 commented 7 months ago

@ivanfei-1 You should check for any UI inconsistencies and fix them.

ivanfei-1 commented 7 months ago

@ivanfei-1 You should check for any UI inconsistencies and fix them.

Fixed in ab0ad9ab