search

Danath / gyp

Automatically exported from code.google.com/p/gyp
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Android backend rejects inputs/outputs with spaces even when this is wrong #432

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The android backend has asserts in action processing to check that inputs and 
outputs to actions do not contain spaces, which were copied from the make 
generator - make will interpret this whitespace as being a filename separator.

However, there's an awkward build step in chromium which needs to be able to 
pass an Android build system make macro as the input: "$(abspath $(call 
intermediates-dir-for,...))" and this triggers the space detection and fails 
makefile generation.

Since we've never had a real problem with files with spaces in the name I'm 
going to disable the asserts for now, but it would be nice to try and come up 
with a better solution to this...

Original issue reported on code.google.com by torne@chromium.org on 3 Jun 2014 at 1:20

GoogleCodeExporter commented 9 years ago

Original comment by torne@chromium.org on 3 Jun 2014 at 1:20

GoogleCodeExporter commented 9 years ago 
sbc@ pointed out that we can just check for the string starting with $( and 
that should be good enough to distinguish make expansions from regular strings. 
I'll do that instead of disabling the asserts.

Original comment by torne@chromium.org on 4 Jun 2014 at 10:11

GoogleCodeExporter commented 9 years ago 
Android generator is being removed.

Original comment by torne@chromium.org on 8 May 2015 at 5:55