Dance-Data-Project / smith-capstone-23

MIT License
0 stars 1 forks source link

Reorganizing folders #43

Closed raevard closed 1 year ago

raevard commented 1 year ago

I moved RMDs into two subfolders

I also updated all file pathways to use the here package, which identifies the project's home folder ("smith-capstone-23") then finds any subfolders or documents which you specify after that. This means we that the file pathways should be compatible no matter the device.

Further, I updated RUN_ALL to run all RMDs in both subfolders, and produce outputs within those folders.

q-w-a commented 1 year ago

Great job Rose!! I think this file organization will be easier to work with.

Here are a couple things to think about:

1) in RUN_ALL.R, the infrastructure code should be run before the exploration code, since some of the files in the explorations folder may depend on the infrastructure code. Also, the order in which the infrastructure files are run is important in some cases -- filter_out_filings depends onload_wrangle_filter.Rmd. I added a commit that addresses this.

3) Another thing I noticed was that filter_filings.Rmd uses the file data_filter_990.RDS, which the current version of load_wrangle_filter did not generate, so I added a line to generate this file so that the filtering file will knit.

raevard commented 1 year ago

Thanks for noticing and making those changes, Quinn!!