55 handle discrepancies

[q-w-a]

This addresses:

• Changing how get_df retrieves all variables for a given structure to better account for the nested structure
• Add warnings to get_df function if you're extracting endowment variables, because we want to be consistent about this and use endowments_by_most_recent_filings.RDS, which contains all schedule D variables. If you need variables not included in this data frame, but also need to use endowment variables, you can join by fiscal year and EIN
• Updating cross referencing file to incorporate all schedule information as well as look at positive or negative differences
• Generating a data frame endowments_by_most_recent_filings.RDS that takes the values from the most recent filing available. This also means we can look at data further back, as far as 2011 or 2010, since we now make full use of the CYM4 column

[raevard]

More detailed code review notes:

• line 106, case_when, did not work until I changed the first case to be variable_name == paste0("CY", base_name) ~ fiscal_year -0 (I added a commit for this)
• It is unclear where discordant_data.RDS originates from; which .RMD does it come from? Are there other files that you need to run before running this one?
• There are two documents with the same name, one in exploration and infrastructure- what's the difference between them?
• Receiving printed a warning for every single loop applying get_df was startling at first- it made me worry that I was applying something wrong, though I was just running your code.

[q-w-a]

Hi Rose,

Thank you for pointing these things out!

I'm going to look into each further and address these things in another couple commits. I'm concerned about why bullet 1 would be throwing an error; I'm going to try to recreate that locally. On bullet 2, it comes from cross_referencing.Rmd; I'll make a note of that in the document (though it should be resolved if you run RUN_ALL.R rather than knitting it individually). On bullet 3, I'll delete the one in explorations; I moved the file but apparently this did not delete the original.