search

DandelionSprout / adfilt

The place where I, DandelionSprout, store my web filter lists for countless topics, including my Nordic adblock list. As simple as that, really.
Other
1.49k stars 149 forks source link

Invalid relative path in `AntiMalwareAdGuard.txt` (only AdGuard related) #1034

Closed Alex-302 closed 4 months ago

Alex-302 commented 4 months ago

Describe the problem below this line as meticulously and detailed as possible (incl. pagelinks if any)

Hi It seems the relative path is incorrect in https://raw.githubusercontent.com/DandelionSprout/adfilt/master/Alternate%20versions%20Anti-Malware%20List/AntiMalwareAdGuard.txt:

!#include uBO%20list%20extensions/Dandelion%20Sprout's%20Anti-Malware%20List%20—%20AdGuardOnlyEntries.txt

because uBO%20list%20extensions/Dandelion%20Sprout's%20Anti-Malware%20List%20—%20AdGuardOnlyEntries.txt does not exist in https://raw.githubusercontent.com/DandelionSprout/adfilt/master/Alternate%20versions%20Anti-Malware%20List/

I think the correct relative path is ../uBO%20list%20extensions/Dandelion%20Sprout's%20Anti-Malware%20List%20—%20AdGuardOnlyEntries.txt

Add screenshots below if needed

No response

Add a screenshot of the extension's logger

Invalid relative path in AntiMalwareAdGuard.txt - filter does not build by AdGuard's Filters Compiler.

Which adblocker(s) did you use when testing this?

AdGuard (Gratis browser versions that aren't Manifest V3 nor Safari)

Adblocker version(s)

AdGuard 4.3.46

Which filterlists did you use? Failing to tell this with at least 10 letters or 1 image, will close the report until it has been told.

Dandelion Sprout's Annoyances List

Which browser(s) did you use when testing this?

Google Chrome (Manifest V2)

Browser version(s)

Chrome 122 x64

Which OS(s) did you use when testing this?

Windows 10

OS version(s)

Windows 10 x64

Alex-302 commented 4 months ago

No, it is not an error according to uBO specs. Our is a bit different. Should be handled on our side.

Alex-302 commented 4 months ago

@DandelionSprout Could you please temporary change !#include uBO%20list%20extensions/Dandelion%20Sprout's%20Anti-Malware%20List%20—%20AdGuardOnlyEntries.txt to !#include ../uBO%20list%20extensions/Dandelion%20Sprout's%20Anti-Malware%20List%20—%20AdGuardOnlyEntries.txt ?

This include is ignored by uBO, but will help until our compiler is not updated.

Sorry for bothering)

DandelionSprout commented 4 months ago

Uh, okay, sure, huh.

Alex-302 commented 4 months ago

Thanks)

iam-py-test commented 4 months ago

Wait, AdGuard allows including files outside the current directory? uBo doesn't. Thanks

DandelionSprout commented 4 months ago

…Oh. That explains a bit. I was occupied with other things yesterday (mostly to complain about diet soda to my secretary), and didn't realise at the time that the folder system was unusual like that. I'll handle a proper !#include system once I've had some breakfast; thanks for the heads-up, iam-py-test.

DandelionSprout commented 4 months ago

https://github.com/DandelionSprout/adfilt/commit/9a8c78847181b329da0b9a61c1e147bf3fd971a9 should probably make the situation better overall.

Alex-302 commented 4 months ago

@DandelionSprout

a8c788 should probably make the situation better overall.

Thanks) Will look on the next build (3p filters compiled every 4 hours)

Alex-302 commented 4 months ago

All good)