DandelionSprout / adfilt

The place where I, DandelionSprout, store my web filter lists for countless topics, including my Nordic adblock list. As simple as that, really.
Other
1.52k stars 149 forks source link

The website mcpedl.com becomes mostly unusable when using the Annoyances filterlist due to the blockage of "smartbanner.js" #1065

Closed legendary-creeper closed 1 month ago

legendary-creeper commented 1 month ago

Describe the problem below this line as meticulously and detailed as possible (incl. pagelinks if any)

The entire mcpedl.com site becomes unusable when "smartbanner.js" is being blocked. Images and other resources do not load. ReCaptcha loads indefinitely, and other unintended behavior occurs.

This issue is resolved if you apply the following rule in your personal filter:

.smartbanner.js$badfilter

Add screenshots below if needed

No response

Add a screenshot of the extension's logger

image

Which adblocker(s) did you use when testing this?

uBlock Origin

Adblocker version(s)

1.60.0

Which filterlists did you use? Failing to tell this with at least 10 letters or 1 image, will close the report until it has been told.

https://raw.githubusercontent.com/DandelionSprout/adfilt/master/AnnoyancesList

Which browser(s) did you use when testing this?

Brave Browser

Browser version(s)

1.70.126

Which OS(s) did you use when testing this?

Linux

OS version(s)

Linux Mint 22 Cinnamon

DandelionSprout commented 1 month ago

.smartbanner.js is typically used to block various "Download our app" banners on many other sites, but I'll certainly take a look later tonight into how mcpedl are using scripts with such names.

legendary-creeper commented 1 month ago

Mcpedl.com does have such a banner on mobile devices, but for some to me unknown reason the blockage causes the website to malfunction on Desktop.

Tmp341 commented 1 month ago

I don't have any problem here (except that huge space above articles):

uBlock Origin: 1.60.0
Firefox: 131
Windows 10 x64

1

DandelionSprout commented 1 month ago

Makes me think about that far from all issue reports I receive for my lists have screenshots of the reported pages. I was eventually able to find larger problems on one of the gamemods' pages (Tested with https://mcpedl.com/slime-ii/), where the problem is pretty big:

With `.smartbanner.js`: ![image](https://github.com/user-attachments/assets/0a62bc11-b79e-4e02-a490-87d5057b0b22)
When whitelisting `.smartbanner.js`: ![image](https://github.com/user-attachments/assets/f7a0f0e1-12cc-417f-9e28-db53f028a7cf)

After thinking about my options, I'll go with changing the .smartbanner.js entry into .smartbanner.js$domain=~mcpedl.com, which seems to work in my tests.