search

DandelionSprout / adfilt

The place where I, DandelionSprout, store my web filter lists for countless topics, including my Nordic adblock list. As simple as that, really.
Other
1.3k stars 143 forks source link

TwitterPureReadingExperience hides lists of followes and following #122

Closed Jorengarenar closed 3 years ago

Jorengarenar commented 3 years ago

Describe the problem below this line as meticulously and detailed as possible:

When checking the list of followers/following, it appears empty. Disabling filter list makes them appear again.

Which adblocker(s) and version did you use when testing this?

Adblocker version(s): v1.30.2

Which filterlists did you use? Failing to write this will result in instant report closing.

Which browser(s) and version did you use?

(Optional) Which OS and version did you use?

OS version: 5.8.14-arch1-1

DandelionSprout commented 3 years ago

It will be pretty difficult for me to test this, since I haven't had a Twitter account since June 2017 (Nowadays I just browse a small handful of comedy accounts there). Nevertheless I can try to make the existing entries more narrow within a couple hours in the hope that it'll go better.

DandelionSprout commented 3 years ago

Okay, I've now given it a shot as per list version 11October2020v2-Alpha.

Jorengarenar commented 3 years ago

Followers are back, but so is "Who to follow"

Jorengarenar commented 3 years ago

Lists are visible, but the only thing removed from 'Who to follow" it this text itself

DandelionSprout commented 3 years ago

In addition to the above stuff, I've recently moved my main setup from Nano Adblocker to uBlock Origin, and was surprised to see that the </> button in uBO's logger didn't re-display most of the hidden elements, making it considerably harder for me to see what turned-on entries are actually hiding.

As such, I apologise in advance for how this will take me considerably longer to fix than usual.

DandelionSprout commented 3 years ago

Okay, so having now checked out the list on Firefox, and googling around to remember what the "Who to follow" menu was:

Can you (or other Twitter account owners) see if twitter.com#?#div:not([class*=" "]) > div > div:-abp-has(> aside [data-testid$=-follow]) work for you?

Jorengarenar commented 3 years ago

Still the same

Yuki2718 commented 3 years ago

I'm not sure if I understand what is the issue correctly, but if it's that Who to follow in Twitter Home is not hidden, on my account it's perfectly hidden by Pure Reading Experience List (##div:has(:scope > aside[role="complementary"])) as well as What's happening (##div[data-testid=sidebarColumn] section > div[aria-label]). ##div:not([class*=" "]) > div > div:-abp-has(> aside [data-testid$=-follow]) also works but is redundant. I wonder if @Jorengarenar uses other lists or extension which interferes with Twitter.

Jorengarenar commented 3 years ago

The ones from sidebar are hidden. The problem are the "Who to follow" suggestions appearing in feeds (especially on users' profiles). Tweet, tweet, tweet and then "Who to follow".

Yuki2718 commented 3 years ago

@Jorengarenar Test twitter.com##div[aria-label^=Timeline] > div[style] > div[style]:has([data-testid$=-follow])

Jorengarenar commented 3 years ago

This is it. "Who to follow" is no more

peace2000 commented 3 years ago

I would change it to this twitter.com##nav[aria-label][role="navigation"] + div > section > div[aria-label^=Timeline] > div[style] > div[style]:has([data-testid$=-follow]) because otherwise there will be breakages on a separate page that lists similar people to follow.

Sample page: https://twitter.com/i/connect_people?user_id=18932374

Breakage: kuva

No breakage: kuva

Yuki2718 commented 3 years ago

FYI now "Who to follow" in timeline is not always under ##nav[aria-label][role="navigation"] + div. cf. https://old.reddit.com/r/uBlockOrigin/comments/kcawz5/is_this_possible/