search

DandelionSprout / adfilt

The place where I, DandelionSprout, store my web filter lists for countless topics, including my Nordic adblock list. As simple as that, really.
Other
1.3k stars 143 forks source link

Submission #199

Closed iam-py-test closed 2 years ago

iam-py-test commented 2 years ago

Which entry/entries are you submitting?

Warning: R1ckroll.

https://www.youtube.com/watch?v=rW7hXs-81hM

Which things do they block, hide, or unbreak?

This is a r1ckroll link (1 not i used to prevent detection). I am not sure how this should be added, so I will leave that up to @DandelionSprout .

Which of my lists are you submitting it to?

R1ckroll link identifier

Which adblocker(s) and version did you use when writing and testing the entries?

Other(s):

Adblocker version(s):uBlock Origin development build v1.35.3rc3

Which filterlists did you use? Failing to tell this will temporarily close the report until it has been told.

Same as #198

(Optional) Which browser(s) and version did you use?

N/A

DandelionSprout commented 2 years ago

Nominally they're supposed to be submitted to https://rickrolldb.com/ , but their list hasn't been updated since March 2019.

Whereas https://raw.githubusercontent.com/DandelionSprout/adfilt/master/RickrollLinkIdentifier.txt only really covers videos that are used pretty frequently in 'rolling.

So I don't have any immediate solutions.

iam-py-test commented 2 years ago

@DandelionSprout based on the comments, that video has been used often for rickrolling. However, I can amend the description to contain a real live rickroll video. (i.e. one someone used to rickroll an entire Google Meet call including me)

iam-py-test commented 2 years ago

Also, I tried visiting the site you posted & got a warning.

krystian3w commented 2 years ago

Maybe darude sandstorm need similar filter list.

krystian3w commented 2 years ago

@DandelionSprout new:

youtube.com/watch?v=iik25wqIuFo

iam-py-test commented 2 years ago

@DandelionSprout new:

youtube.com/watch?v=iik25wqIuFo

General rule to fix it: ||youtube*.com/*iik25wqIuFo$all Should cover embeds & directly visiting the url

krystian3w commented 2 years ago

I suppose not in this repo due "1%" chance for false positive.

iam-py-test commented 2 years ago

I suppose not in this repo due "1%" chance for false positive.

How can I decrease that chance?

krystian3w commented 2 years ago

Longer ID for other video in the future like: "Ziik25wqIuFo7" or trolling friend by HTML anchors: #iik25wqIuFo

iam-py-test commented 2 years ago

Longer ID for other video in the future like: "Ziik25wqIuFo7" or trolling friend by HTML anchors: #iik25wqIuFo

Also I realized this would also break websites with YouTube and .com in their name (I.e. maybe something like http[:]//iloveyoutubevideos.com/iik25wqIuFo)

iam-py-test commented 2 years ago

Is there a way to limit to use in query params and path? (As that would not block the second use case) I don’t know what can be done about the first apart from using two filters

krystian3w commented 2 years ago

Anybody create list for SponsorBlock:

start in: https://youtu.be/byz_0l9RbYc?t=87 and gone in 90 second.

In uBO maybe hard bannish seconds without use nice regex and need exist t param. Also possible use these syntax: 1m27s

krystian3w commented 2 years ago

1 Bilion/miliard (one thousand million) views has been planted:

https://www.instalki.pl/aktualnosci/internet/48982-rick-astley-never-gonna-give-you-up-youtube.html