search

DandelionSprout / adfilt

The place where I, DandelionSprout, store my web filter lists for countless topics, including my Nordic adblock list. As simple as that, really.
Other
1.3k stars 143 forks source link

ie=UTF-8 string on Google search #260

Closed pawelkoszalin closed 2 years ago

pawelkoszalin commented 2 years ago

Describe the problem below this line as meticulously and detailed as possible (incl. pagelinks if any)

When i wants to search something on my mobile, with chrome browser, your rules adds "ie=UTF-8" string to search link, and it broke polish specific characters.

Add screenshots below if needed

20210830_203921

Add a screenshot of the extension's logger

No response

Which adblocker(s) did you use when testing this?

AdGuard (Paid desktop version)

Adblocker version(s)

Adguard for Android (pro version)

Which filterlists did you use? Failing to tell this will temporarily close the report until it has been told.

Screenshot_20210830-201536_AdGuard

Which browser(s) did you use when testing this?

Google Chrome

Browser version(s)

No response

Which OS(s) did you use when testing this?

Android

OS version(s)

No response

Faisalnd commented 2 years ago

Even in Arabic the same thing Screenshot_20210830-232100_Chrome Screenshot_20210830-232046_Chrome

krystian3w commented 2 years ago

How this works with:

?

pawelkoszalin commented 2 years ago

How this works with:

  • uBO + Google Search Fixer + Firefox Fenix or Legacy 68.X
  • uBO + Kiwi (based on Chromium 93) or Yandex Browser

?

uBO + Firefox beta (Android) - works well uBO + Kiwi - works well

DandelionSprout commented 2 years ago

I'm having problems reproducing this in Chrome 92.0.4515.159 for Android 10 so far this morning. When using Chrome, are you searching from either: 1) The Google search line widget on the homescreen. 2) Chrome's URL bar. 3) By going to google.com and searching from there.

pawelkoszalin commented 2 years ago
  1. Chrome's URL bar.
krystian3w commented 2 years ago

OK, so AdGuard remove 'param' harder or Chrome have very different code of page then compare what we see in Kiwi.

Maybe the best is comment line:

https://github.com/DandelionSprout/adfilt/blob/0f6d27cb47af837675a19228af99024db73b08d2/LegitimateURLShortener.txt#L937

Into adguard own/personal rules temporarily possible copy:

||google.$~xmlhttprequest,removeparam=ei,badfilter

And in free time tests pre procedurual grouping like: env_ublock (or only env_desktop), 'Adguard Windows', 'AdGuard macOS' (can be simplfed to exclude Android app in the safest scenario).

DandelionSprout commented 2 years ago

Can you (pawel) copy and paste the whole URL you get in the "Filter on" scenario in a comment below?

pawelkoszalin commented 2 years ago

On: https://www.google.com/search?ie=UTF-8&client=ms-android-samsung-ss&sourceid=chrome-mobile&oq=%C3%85%C2%BC%C3%83%C2%B3%C3%85%C2%82ty&q=%C3%85%C2%BC%C3%83%C2%B3%C3%85%C2%82ty&no_sw_cr=1&ved=1t%3A46160&zx=1630391050463

Off: https://www.google.com/search?q=%C5%BC%C3%B3%C5%82ty&oq=%C5%BC%C3%B3%C5%82ty&aqs=chrome.0.69i59l3j0i512l2.921j0j9&client=ms-android-samsung-ss&sourceid=chrome-mobile&ie=UTF-8

Search term is: żółty - that's yellow in polish

pawelkoszalin commented 2 years ago

Screenshot_20210831-083327_Chrome

Screenshot_20210831-083426_Chrome

DandelionSprout commented 2 years ago

Okay, I am now clued on to something of some sort. Seems to be a pretty major bug with Google itself, where it converts %C5%BC%C3%B3%C5%82ty into %C3%85%C2%BC%C3%83%C2%B3%C3%85%C2%82ty, causing HTML entity failures.

Are you able to paste @@||www.google.$removeparam=aqs into your AdGuard user filters and see if that fixes anything at all?

pawelkoszalin commented 2 years ago

Works!

https://www.google.com/search?q=%C5%BC%C3%B3%C5%82ty&oq=%C5%BC%C3%B3%C5%82ty&aqs=chrome.0.69i59l3j0i512l2.940j0j9&client=ms-android-samsung-ss&sourceid=chrome-mobile&ie=UTF-8

Screenshot_20210831-090909_Chrome