DandelionSprout / adfilt

The place where I, DandelionSprout, store my web filter lists for countless topics, including my Nordic adblock list. As simple as that, really.
Other
1.3k stars 143 forks source link

Where are the uBO 1.24.5 beta builds? (prev. "I found the problem, and it's a bug in uBO..") #299

Closed DarthVaderJPA3 closed 2 years ago

DarthVaderJPA3 commented 2 years ago

I found the problem, and it's a bug in uBO.. I have this rule in my own filter list: vg.no##+js(abort-current-inline-script.js, Math.floor, g00) It is the same rule as this one (found in DS's Nordic list): vg.no##+js(acis, Math.floor, g00) The only difference is that the rule in my filter list uses the legacy syntax. When the two rules are used together in uBO v1.25.0, this page fails to load!: https://www.vg.no/sport/i/GGbJ04/ In uBO v1.24.4, the two rules can be used together, without causing any issues!

--

EDIT:

You can check if 1.24.5b3 is working and 1.24.5b4 not.

Where can I find those builds now?

Originally posted by @THEtomaso in https://github.com/DandelionSprout/adfilt/issues/7#issuecomment-590391877

Yuki2718 commented 2 years ago

https://github.com/gorhill/uBlock/wiki/Resources-Library

You should omit the .js from the scriptlet name in scriptlet injection filters (eventually in some future this will be the official way to do this).

krystian3w commented 2 years ago

Force update uBO, use outdated browser and uBo is Bad (very Bad Gaga).

krystian3w commented 2 years ago

https://github.com/gorhill/uBlock/commit/034c915f3be1257ed5de638a456e7c95932c553d

DandelionSprout commented 2 years ago

Okay, so let's see if I understand this report correctly: You (DarthVaderJPA1) are wondering where the old beta builds are? This is a rather odd place to ask this, but looking into this, it seems that https://github.com/gorhill/uBlock/tags delete beta builds after the release of a full version. So the closest you can find are 1.24.4 stable, and 1.25.0 stable.

THEtomaso commented 2 years ago

You're talking to a bot. Seems to me that it just copies some random stuff (an old post of mine, in this case), and managed to file a issue report. Don't know where krystian3w found that redirector though, which he mentioned in our chat.

krystian3w commented 2 years ago

Gorhill pin your origin comment into commit if you that mean "redirector".

THEtomaso commented 2 years ago

redirector

I ment that aselink.guru URL. Where did you discover it, in relation to this thing? ..or was it a different issue, all together?

krystian3w commented 2 years ago

Other - to bannish in uBo Badware risk or in "Danedelion Anti-Malware filters list".

In 1% maybe in "UrlHause" or "spam404" projects.

THEtomaso commented 2 years ago

Other

OK, I see. I'm already blocking that whole TLD by default, anyway. :)

iam-py-test commented 2 years ago

That account has been spamming all around I.e. https://github.com/composer/composer/issues/10140

krystian3w commented 2 years ago

Banned on my account, so can't spam in my issues/pr.

iam-py-test commented 2 years ago

Reported to GitHub support for spam Archive of this page as it probably will be deleted when the account is taken down: https://web.archive.org/web/20211013000359/https://github.com/DandelionSprout/adfilt/issues/299

DandelionSprout commented 2 years ago

My impression of GitHub's mod team, is that they're very cautious about banning accounts, failing to ban e.g. serial bullies or outright psychopaths. So I sadly don't think GitHub would be willing to ban an account who has only posted on 2 repos so far.

iam-py-test commented 2 years ago

It’s worth trying anyway

DandelionSprout commented 2 years ago

With OP never replying to this thread ever since, I think I can at least close this thread.