community.spiceworks.com - fake annoyance login pop-ups

krystian3w commented 2 years ago

Prerequisites

[X] This is not a support issue or a question
[X] I performed a cursory search of the issue tracker to avoid opening a duplicate issue
[X] I am running the latest version of uBlock Origin

I tried to reproduce the issue when...

[X] uBO is the only extension
[X] uBO with default lists/settings
[X] using a new, unmodified browser profile

URL(s) where the issue occurs

https://community.spiceworks.com/topic/336962-changing-time-server-w32tm-resync-rediscover-access-is-denied-0x80070005

Describe the issue

Pop-up are back after "3-rd" visit at page (more than two): https://github.com/uBlockOrigin/uAssets/issues/7550

Reproduction is still hard, becasue needed is generate count marked at visit "3-rd".

After while time should be prompt new version at "3-rd" visit.


  var SignupTypes = {
    default:        'default',
    fromPhoto:      'default from photo modal',
    fromNavbar:     'default from navbar',
    fromPanel:      'default from message panel',
    fromFooter:     'default from footer',
    fromRepeatVisit:'Default from 3 visit modal',
    photoModalDelay: '25',
    repeatVisitModalEnabled: false,
    joinFooterEnabled: true,
    photoModalEnabled: true,
    marketingPage: false,
    connectProduct: 1,
  };

showRepeatVisitModal: function() {
    JoinAltModal.delayedShowAltJoinModal('repeat-visit', 6000, {}, JoinAltModal.setRepeatVisitCookie);
  },

Screenshot(s)

obraz

have locked scroll on Full HD monitor but body was longer than 1080px.

uBlock Origin version

1.38.7b12

Browser name and version

Firefox 94

Settings

Enabled: uBo Annoyances

Notes

Oldie "uBo Annoyances" filters still needed, because page use both pop-ups and both have locked scroll.

! https://github.com/uBlockOrigin/uAssets/issues/7550
community.spiceworks.com##.zd-privacy-content
community.spiceworks.com##.join-login-wrapper.join-login-alt--six-second[data-alt-modal]
community.spiceworks.com##.sui-u-no-scroll:style(overflow:auto !important;)

Addition can be: "repeat-visit"

community.spiceworks.com##.join-login-wrapper.join-login-alt--repeat-visit[data-alt-modal]

I no tested cookie-remove named by visit_count with value "3" or stop it "set-timeout" (~6000 ms).

krystian3w commented 2 years ago

uAssets closed without wrote arguments by mapx- hands.

iam-py-test commented 2 years ago

I can't seem to reproduce:

krystian3w commented 2 years ago

Because "looks a familliar" need analyse JS how works:

visit_count

Fastest is force edit cookie from value 0-2 or 4-99+ to 3 and refresh any topic on that page, but nobody prefere malform cookies to reproduce anything.

iam-py-test commented 2 years ago

Because "looks a familliar" need analyse JS how works:

visit_count

Fastest is force edit cookie from value 0-2 or 4-99+ to 3 and refresh any topic on that page, but nobody prefere malform cookies to reproduce anything.

Yep, I can repro. Thanks

iam-py-test commented 2 years ago

Let me look into it

DandelionSprout commented 2 years ago

I had initial problems reproducing it an hour ago, sadly.

iam-py-test commented 2 years ago

I had initial problems reproducing it an hour ago, sadly.

You need to go into Dev Tools & set the cookie _visitcount to 9

iam-py-test commented 2 years ago

I found the following filters fix it:

community.spiceworks.com##+js(cookie-remover,visit_count)
community.spiceworks.com##+js(cookie-remover,last_visit)
community.spiceworks.com##.u-faded-in.is-shown.join-login_alt-modal.sui-u-fadeable.sui-modal_overlay.sui-opt-in

krystian3w commented 2 years ago

Last may break scroll for users with disabled uBO annoyances if cookie-remover works too late on pages.

iam-py-test commented 2 years ago

Last may break scroll for users with disabled uBO annoyances if cookie-remover works too late on pages.

Ok. You can just add the first two. I think all thats needed is 1 but I figured that other cookie is useless anyway

DandelionSprout commented 2 years ago

With what seems to me to be a consensus on community.spiceworks.com##+js(cookie-remover,visit_count), I'll add that one to Browse Websites Without Logging In now. Thanks to you all again.

krystian3w commented 2 years ago

Maybe better mark filter line as incompatible with annoyances.txt by uAssets uBO team, mapx- maybe reject your Issue with mass addition new filters.

DandelionSprout / adfilt