search

DandelionSprout / adfilt

The place where I, DandelionSprout, store my web filter lists for countless topics, including my Nordic adblock list. As simple as that, really.
Other
1.3k stars 143 forks source link

Fix for `BaiduNetdisk` #343

Closed DeepChirp closed 2 years ago

DeepChirp commented 2 years ago 
*$removeparam=from,domain=sogou.com|baidu.com|jetbrains.com|bandcamp.com|apkpure.com

This rule blocks users from saving files in BaiduNetdisk.

iam-py-test commented 2 years ago

Thanks.

DeepChirp commented 2 years ago

@iam-py-test I think the other two filters should also add corresponding comments.

iam-py-test commented 2 years ago

@iam-py-test I think the other two filters should also add corresponding comments.

Ok, give me a sec

iam-py-test commented 2 years ago

Does https://github.com/DandelionSprout/adfilt/commit/734e3a95b45f7afe192c2b805a1cf39d1f5626f0 look like what you were looking for? I added a link to this and https://github.com/DandelionSprout/adfilt/pull/325

DeepChirp commented 2 years ago

Does 734e3a9 look like what you were looking for? I added a link to this and #325

Awesome! And what about @@mailinglist$removeparam=/^utm_/?

iam-py-test commented 2 years ago

Does 734e3a9 look like what you were looking for? I added a link to this and #325

Awesome! And what about @@mailinglist$removeparam=/^utm_/?

I have no idea where that came from. I'm pretty sure that was added way before I was working on this, and the commit logs gave me no answers. My best guess is that it is designed to unbreak mailing lists @DandelionSprout do you know?

DeepChirp commented 2 years ago

It was added in https://github.com/DandelionSprout/adfilt/commit/6dd010c70438a84cae7cf6b683d0d99dc56794ad

iam-py-test commented 2 years ago

It was added in 6dd010c

Ah, thanks! How'd you find that?

DeepChirp commented 2 years ago

It was added in 6dd010c

Ah, thanks! How'd you find that?

You can try git blame However, this commit does not give instructions

iam-py-test commented 2 years ago

It was added in 6dd010c

Ah, thanks! How'd you find that?

You can try git blame

Odd. When I tried that on GH (through the show blame) it showed the wrong commit

iam-py-test commented 2 years ago

However, this commit does not give instructions

Probably something he discovered himself? @DandelionSprout

DeepChirp commented 2 years ago

It was added in 6dd010c

Ah, thanks! How'd you find that?

You can try git blame

Odd. When I tried that on GH (through the show blame) it showed the wrong commit

Yes so I first revert to an older version and then run this command.