DandelionSprout / adfilt

The place where I, DandelionSprout, store my web filter lists for countless topics, including my Nordic adblock list. As simple as that, really.
Other
1.3k stars 143 forks source link

Legitimate URL Shortener breaks many Facebook pages (not profiles) #473

Closed ctp9 closed 2 years ago

ctp9 commented 2 years ago

Describe the problem below this line as meticulously and detailed as possible (incl. pagelinks if any)

I'm not sure how to log or describe this - but Facebook pages (not profiles) get significantly broken. If you own a page and go to "Manage" your page - lots of elements simply no longer load with Legitimate URL Shortener activated.

Pages freeze and are unable to render the functions of the requested page. Refreshing does not fix it, but only disabling the Legitimate URL Shortener fixes all these issues.

To replicate all these issues - you need to have created your own Page, and then try to Manage / edit Settings, etc.

Facebook pages use detailed URL descriptions for editing pages, and I think there are many conflicts in the current rules that are too restrictive and break everything to do with Page management.

Add screenshots below if needed

No response

Add a screenshot of the extension's logger

uBlock_Origin_logger.txt

Which adblocker(s) did you use when testing this?

uBlock Origin

Adblocker version(s)

uBlock Origin 1.40.8

Which filterlists did you use? Failing to tell this will temporarily close the report until it has been told.

uBlock filters uBlock filters – Badware risks uBlock filters – Privacy uBlock filters – Resource abuse uBlock filters – Unbreak AdGuard Base EasyList AdGuard Tracking Protection AdGuard URL Tracking Protection Block Outsider Intrusion into LAN Online Malicious URL Blocklist Phishing URL Blocklist PUP Domains Blocklist Fanboy’s Annoyance uBlock filters – Annoyances Peter Lowe’s Ad and tracking server list Actually Legitimate URL Shortener Tool oisd full Spam404

Which browser(s) did you use when testing this?

Firefox

Browser version(s)

97.0b9

Which OS(s) did you use when testing this?

(Other)

OS version(s)

Windows 11 (21H2) Version 10.0.22000 Build 22000.469

DandelionSprout commented 2 years ago

I don't have a Facebook account of my own, so I'll assign this to @iam-py-test for the immediate time being.

iam-py-test commented 2 years ago

I don't have a Facebook account. @ctp9 please take a screenshot of the uBlock Origin logger while reproducing the issue

ctp9 commented 2 years ago

Updated original post with logger text file attached.

Page management tools seemed to work better today - so I partially suspect Facebook servers themselves were acting up when I submitted this report yesterday. But do still take a look through the log please and see if you can find any issue(s) and/or if there's any room for improvement/optimization, etc.

I'll upload more logs in the coming days from various sections of Facebook where elements get broken.

iam-py-test commented 2 years ago

@ctp9 please try the following filter in your My Filters tab: @@||facebook.com^$removeparam=__s

ctp9 commented 2 years ago

Testing - will report soon.

Nojuuu commented 2 years ago

Could also be reason for some of the problems: https://bugzilla.mozilla.org/show_bug.cgi?id=1735595 https://bugzilla.mozilla.org/show_bug.cgi?id=1752270

iam-py-test commented 2 years ago

Could also be reason for some of the problems: https://bugzilla.mozilla.org/show_bug.cgi?id=1735595 https://bugzilla.mozilla.org/show_bug.cgi?id=1752270

Hmm... @ctp9 try installing uBlock Origin in a Chrom(ium) browser and add Legit URL, see if that is the issue In the mean time, let me see if I can convince someone in my household who has a Facebook account to help me repro

ctp9 commented 2 years ago

Could also be reason for some of the problems: https://bugzilla.mozilla.org/show_bug.cgi?id=1735595 https://bugzilla.mozilla.org/show_bug.cgi?id=1752270

Hmm... @ctp9 try installing uBlock Origin in a Chrom(ium) browser and add Legit URL, see if that is the issue In the mean time, let me see if I can convince someone in my household who has a Facebook account to help me repro

One of the responses on the Mozilla bug tracker:

"Chrome has the same issue, it's a Facebook problem."

DandelionSprout commented 2 years ago

I can borrow my mom's Facebook account to do surface-level skim tests, but I'd need to set off an hour to do so.

iam-py-test commented 2 years ago

@ctp9 did the filter @@||facebook.com^$removeparam=__s fix the issue? As Facebook is very popular, I'd like to fix this

ctp9 commented 2 years ago

@ctp9 did the filter @@||facebook.com^$removeparam=__s fix the issue? As Facebook is very popular, I'd like to fix this

I'm still testing but so far seems to be working better than when I first submitted my report. I am still, however, occasionally experiencing the Mozilla bugs reported earlier regarding image loading when administering my own Pages, which seems to be universal across Chrome and Firefox.

ctp9 commented 2 years ago

I can borrow my mom's Facebook account to do surface-level skim tests, but I'd need to set off an hour to do so.

Please also check out the "Activity Log" in the settings section of Facebook. Some things get broken there also when expanding/collapsing section trees. The entire Activity Log section sometimes stops loading with Legitimate URL Shortener enabled.

iam-py-test commented 2 years ago

If that filter seems to help, I'm going to add it for now

ghost commented 2 years ago

So, is this reproduceable?

iam-py-test commented 2 years ago

So, is this reproduceable?

Do you have a FaceBook account? I don't and neither does Imre, so reproing is hard

ghost commented 2 years ago

Do you have a FaceBook account?

yes

ghost commented 2 years ago

so I created a fb page, and I haven't observed any issues

iam-py-test commented 2 years ago

so I created a fb page, and I haven't observed any issues

Probably the temp fix from https://github.com/DandelionSprout/adfilt/commit/6f22b1c686e0ffa23e77a0bc82beb5eb254b4888 Try adding @@||facebook.com^$removeparam=__s,badfilter and retesting.

ghost commented 2 years ago

no issue spotted on my end

iam-py-test commented 2 years ago

Even with that filter + clearing cache & cookies (and re-sign in)?

ghost commented 2 years ago

I'll see if I can make some time available for more testing.

DandelionSprout commented 2 years ago

I sadly can't help after all, because my mom's PC died some days ago (A missing CPU retention bracket led to fan mounting problems, in turn causing bent pins on the CPU socket), and they sure haven't had any haste in pursuing a new PC to put their SSD into.

krystian3w commented 2 years ago

If the pins haven't flown off the processor or motherboard, you can try to straighten them out instead of throwing +90% of the computer away in the electro-junk.

I would consider if you can buy a used cpu or motherboard itself very cheaply (cheaper than some finished PC with 6th or newer generation Intel if parent don't like oldie AMD and AMD Ryzen).

ghost commented 2 years ago

I haven't reproduced any breakage.

ctp9 commented 2 years ago

At the moment things are working good. It may have been the Facebook / Mozilla bugs that were described earlier after all...

https://bugzilla.mozilla.org/show_bug.cgi?id=1735595 https://bugzilla.mozilla.org/show_bug.cgi?id=1752270

iam-py-test commented 2 years ago

If Facebook is still working well, I think I can close the issue

ctp9 commented 2 years ago

Wait - I'll test a few more times and we will close it with my final confirmation. Just been busy and didn't get to re-test since last time.

DandelionSprout commented 2 years ago

Given there seemingly hasn't been any problems with this from any involved party for approx. 7 weeks by now, I think it's safe to declare this a closed case for now. Comments will remain open.