search

DandelionSprout / adfilt

The place where I, DandelionSprout, store my web filter lists for countless topics, including my Nordic adblock list. As simple as that, really.
Other
1.3k stars 143 forks source link

"NorwegianList.txt" broken in DNSBL/pfblockerng/pfsense #52

Closed janegilv closed 4 years ago

janegilv commented 4 years ago

Describe the problem below this line as meticulously and detailed as possible:

DNSBL/pfblockerng stops processing files which contain [Adblock Plus ...]. Since this was removed from your file DNSBL blocks all dns-lookups to all domains included in this file, which means quite a lot of sites gets broken. This file is probably automatically included in pfblockerng because it is part of easylist.

Any chance this line could be re-added?

Which adblocker(s) and version did you use when testing this?

Other(s): DNSBL/pfblockerng/pfsense

DandelionSprout commented 4 years ago

I admit to have been completely unaware that PFBlockerNG included my list by default, or that they for some reason still used the uBlock Origin-intended main version of that list.

Although I don't have a PFBlockerNG setup of my own to test all this with: The best solution for this that I can find, would be to tell them to replace it with the hosts versions of my list. But first I'd need to find some way to properly contact them. Surely they must have some issue tracker or support E-mail address somewhere on the internet?

DandelionSprout commented 4 years ago

I've now attempted to contact them about it though https://github.com/pfsense/FreeBSD-ports/pull/713, which was my best guess as to an easily understandable way to tell them about it (although it doesn't seem to be monitored all that much). In the meantime you can try out the hosts version and/or the Adblock Plus version of my list instead.

joachimtingvold commented 4 years ago

Well, what determines what is included in your hosts version? AFAIK, the [Adblock Plus] is there to tell PFBlockerNG how to treat the entries, and I believe it only includes entries where the rule would match the whole domain (and not a specific URL).

In other words; if you do not do the same logic in your hosts file, the issue would still pertain (just in another way).

DandelionSprout commented 4 years ago

With only a few exceptions, the whole-domain entries are almost identical between my uBO version and the Hosts version, except of course for removing wildcard entries and $ denominators from the Hosts version. This means that e.g. euroads.no is blocked in both those versions (and in the other 14-ish versions I have).

DandelionSprout commented 4 years ago

It'd actually be even more preferable for me to submit the domains version to them instead, as it is slightly more frequently updated, but I'd need some kind of confirmation that the wildcard entries at the bottom doesn't break pfBlockerNG either.

DandelionSprout commented 4 years ago

My understanding of the current situation, is that the uBO list version will almost guaranteedly be natively replaced by the hosts version in pfBlockerNG v2.2.5_27 (The next release), if anyone here were to be wondering about it.

DandelionSprout commented 4 years ago

So since this matter has (presumably) been fixed in pfBlockerNG-devel for several weeks, but probably won't be fixed in stable pfBlockerNG for several more months due to its very infrequent updates, do any of you guys have any opinions on whether this issue has been resolved or should stay open?

eN0Rm commented 4 years ago

Updated pfBlockerNG to 2.2.5_27 still had problems with this list.

DandelionSprout commented 4 years ago

I'm going to need a bit more information than that to begin to look into that. Does 2.2.5_27 still use the uBlock Origin list version by default? Or does it use the hosts file? Which list version are you using, maybe even both? Is it the same problem as before, or is it something else? Et cetera, et cetera.

eN0Rm commented 4 years ago

This is the link to the list in pfBlockerNG 2.2.5_27 https://raw.githubusercontent.com/DandelionSprout/adfilt/master/NorwegianList.txt

DandelionSprout commented 4 years ago

I for one was able to confirm on a stock install some days ago that the link was https://raw.githubusercontent.com/DandelionSprout/adfilt/master/NorwegianExperimentalList%20alternate%20versions/AdawayHosts; however, your comment confirms one of my theories well enough that there'd be no need for me to do a "Word against word" debate by now.

I'll add a note to the uBO version real quick to hopefully mitigate the situation furthermore.

DandelionSprout commented 4 years ago

With the release of pfSense 2.4.5 earlier today, and no reported problems with the Hosts version in the past 4 months once that version had been applied, it's now time to declare this a resolved case. 🎉