DandelionSprout / adfilt

The place where I, DandelionSprout, store my web filter lists for countless topics, including my Nordic adblock list. As simple as that, really.
Other
1.52k stars 150 forks source link

General filter chit-chat №2 #63

Closed DandelionSprout closed 1 year ago

DandelionSprout commented 4 years ago

Note, 13th of February 2023: Next de facto discussion place until further notice is at #779.

————————————

So today I learned that GitHub threads max out at 2,500 comments, despite nothing and no one ever telling me about that previously, let alone GitHub's help pages. So here's thread number 2!

This thread is a megathread about adblock discussions in general. Here one can request syntax help, reproduction confirmations, info about differences between adblockers, assistance with making new lists, and so on. They'll be answered or considered by the biggest Adfilt contributors, and occasionally by members of the uBlock Origin development team (although in an unofficial fashion). (This header section was last updated on the 24th of April 2019 by DandelionSprout.)

Same non-obligatory rules apply as in the previous thread (Rules can be amended by Dandelion Sprout on very short notice, but this happens pretty rarely):

DandelionSprout commented 4 years ago

(To THEtomaso) ny1.no redirects me to https://kostholdsbutikken.no/, which does not have any visible ads that I can see.

(To gwarser) Such a Slack channel would've spread out adblock maintainer discourse a bit too widely, so I'm holding out on it for the immediate time being.

liamengland1 commented 4 years ago

Wow, this morning ny1.no looked like this: https://web.archive.org/web/20200311/https://ny1.no/

DandelionSprout commented 4 years ago

I know that there's been an increased effort from Faktisk.no (which is essentially the Norwegian version of Snopes) to criticise fake COVID news, so it's perfectly plausible that ny1.no could've chose to redirect (Possibly temporarily so) to a healthfood site to try to save what little reputation they ever had.

krystian3w commented 4 years ago
a, .about .readmore, .closeBtn, .infoArea .details a {
    cursor: url("cursor.png"), pointer;
    cursor: -webkit-image-set(url('cursor.png') 1x, url('cursor_hd.png') 2x), pointer;
}

/cursor.png$image,domain=iliketoplay.dk /cursor_hd.png$image,domain=iliketoplay.dk

I cannot test hdpi (cursor_hd.png) - maybe need use "path" /Assets/Css/.

DandelionSprout commented 4 years ago

*/Assets/*/cursor.png seems to work well enough for me, so I'll add that as well as */Assets/*/cursor_hd.png just to be sure.

liamengland1 commented 4 years ago

why not use style?

DandelionSprout commented 4 years ago

A prototype version of that list used :style extensively, but I recall that I completely rewrote it after it was brought to my attention that it could break sites that never had custom cursors to begin with, and also to increase compatibility with other extensions like AdGuard.

liamengland1 commented 4 years ago

Does the custom cursors list cover when sites change the default cursor behavior? Example on that site iliketoplay.dk when you mouse over the text at the top, the cursor should look like

image

but the site overrides it with a css declaration.

Also, do you have an anti-smooth scrolling list (another annoying thing -IMO - that site does)?

DandelionSprout commented 4 years ago

IIRC, there are so, so, so many sites out there who insist on using the regular triangular cursor when hovering over text, that it'd be damn near impossible for me to consistently override that insistence of theirs, sadly.

I don't have an anti-'Smooth scrolling' list for the time being, mostly because I use Chromium Wheel Smooth Scroller anyway, which also helps override site-specific scrolling speeds to the best of my knowledge.

THEtomaso commented 4 years ago

@DandelionSprout: Issue: New deblurrer needed for vg.no. Example: https://www.vg.no/nyheter/i/y3Mka2/ Note: vg.no##._3HQTw:before works, but looks awfully dynamic, so a better solution is probably required.

krystian3w commented 4 years ago

##div[data-test-tag="timestamp"] + div:before

?

Yuki2718 commented 4 years ago

I've noticed substantially more errors by AdGuard Base List than usual:

ubo-err

It seems its all related to style syntax, but I can't tell what's wrong - tho at first they looked generic rules which uBO doesn't support, actually they are all specific rules e.g. turbobit.net#$?#html[-ext-has="> body"] { background: none!important; }

gwarser commented 4 years ago

Styling using procedural filters is not supported (:has() for ex.). :style(remove: true;) - what it is? Does it remove some style? Not supported then.

krystian3w commented 4 years ago

:style(remove: true;) ~ :remove()

IMO glitch https://github.com/PolishFiltersTeam/PolishSocialCookiesFiltersDev/commit/ad7e6c01246caf0e24837aceb47f781f3f026f34#commitcomment-37755447

bmw-motorrad.pl#$?#.cookielayer { remove: true; }

good

bmw-motorrad.pl##.cookielayer:remove()

good

bmw-motorrad.pl#?#.cookielayer:style(remove: true;)

bmw-motorrad.pl##.cookielayer:style(remove: true;)

invalid / unsupported syntax / glitch after translate into :style() but omit :remove().

gwarser commented 4 years ago

remove should be supported in dev builds https://github.com/uBlockOrigin/uBlock-issues/wiki/Procedural-cosmetic-filters#subjectremove

AdGuard's cosmetic filter syntax { remove: true; } will be converted to uBO's :remove() operator internally.

Yuki2718 commented 4 years ago

All right, then they should have increased the use of such rules recently. Thx for explanation : )

THEtomaso commented 4 years ago

So, what's up with hpHosts.. Discontinued, or simply relocated?

--

EDIT: Discontinued, it would seem: https://forums.malwarebytes.com/topic/256701-what-happened-to-hphosts-website/?tab=comments#comment-1370003 :(

Yuki2718 commented 4 years ago

Quite a shock...

krystian3w commented 4 years ago

music.apple.com - hard coded social share links:

$('button[aria-label="Open sharing menu"]').click();

Yuki2718 commented 4 years ago

music.apple.com

I was redirected to https://www.apple.com/apple-music/.

krystian3w commented 4 years ago

https://music.apple.com/us/album/segador-de-almas/1470036829

Appear after click (in html code) and disappear (form html code) after end mouseover element.

liamengland1 commented 4 years ago

music.apple.com

I was redirected to https://www.apple.com/apple-music/.

https://music.apple.com/us/album/after-hours/1499385848

THEtomaso commented 4 years ago

Looks like it's official now.. HpHosts has been discontinued!: https://forums.malwarebytes.com/topic/256701-what-happened-to-hphosts-website/?tab=comments#comment-1370008 :(

@gorhill Guess uBO's filter list will have to be updated.

krystian3w commented 4 years ago

forums.malwarebytes.com##.cTopicPostArea:has(.cGuestTeaser) community.ccleaner.com##.cTopicPostArea:has(.cGuestTeaser)

community.ccleaner.com and prestashop.com/forums/ - no allow send post without create account (as guest).

gwarser commented 4 years ago

https://github.com/uBlockOrigin/uBlock-issues/issues/971

DandelionSprout commented 4 years ago

I knew that HpHosts' full version had become officially discouraged 2-months-ish ago, but this was news to me.

Looking into the code of the Firefox version, it seems to me that hpHosts has been turned into internal hexadecimal code in the Malwarebytes Browser Guard extension. Someone at Malwarebytes seem to really have gone extra distance to ensure that no other extensions could ever use those lists anymore... 😑

image

krystian3w commented 4 years ago

Register form :door: and big blank "header":

photoblog.pl###frontpage .frontpage-teaser-photo-container[style*="background-image: url()"] h1:style(margin-top: 45px !important;)
photoblog.pl###frontpage .frontpage-teaser-photo-container[style*="background-image: url()"]:style(height: 225px !important;)
photoblog.pl##.frontpage-teaser-photo-container > .register > #registration-form
DandelionSprout commented 4 years ago

I've now added that 3rd entry. The former two is on my to-do list for Nano Placeholder Buster.

Yuki2718 commented 4 years ago

Regarding this issue https://github.com/AdguardTeam/AdguardFilters/issues/52866 I don't see the anti-adblock with uBlock (while do see with AdGuard ext, mostly the same settings as far as blocked contents are concerned) , but apparently there's no difference on what's are blocked/not blocked. Can anybody explain this? Confirmed on Firefox and Brave (its blocker turned off).

DandelionSprout commented 4 years ago

I know that uAssets added a fix for that site anyway since you wrote that comment, meaning that a straightforward comparison is most likely no longer possible.

Yuki2718 commented 4 years ago

Not a big deal worth wasting your time, but I wonder if @uBlock-user saw the anti-adblock.

uBlock-user commented 4 years ago

Yes, I did and it was twice.

Yuki2718 commented 4 years ago

Yes, I did and it was twice.

Thank you, probably I missed sth.

krystian3w commented 4 years ago

community.spiceworks.com##.join-login-alt--six-second.join-login-alt.join-login-wrapper community.spiceworks.com##body.sui-u-no-scroll:style(overflow:auto !important;)

obraz

Normal login use other pop-up ID/Class and node.

THEtomaso commented 4 years ago

@DandelionSprout: https://github.com/DandelionSprout/adfilt/issues/63/#issuecomment-604334693

THEtomaso commented 4 years ago

@DandelionSprout:

https://github.com/DandelionSprout/adfilt/commit/53fd45b34a4c13b728df7717010d74203ee32a9f

Different solution needed here: https://www.vg.no/nyheter/innenriks/i/3JbRzv/

THEtomaso commented 4 years ago

I just noticed some big, and very intrusive, GDPR popups at agderposten.no and hallingdolen.no. Simply blocking them will result in breakage (e.g. everything in the site footers will be unclickable). Any way to accept the popups automatically, and prevent breakage?

krystian3w commented 4 years ago

Simply blocking them will result in breakage - (...) footer

agderposten.no,hallingdolen.no##div[class*="_isSimple_"][class*="_prompt_"]

still break footer? @kiboke why addon hide this but list for ABP/uBO not?


Any way to accept the popups automatically, and prevent breakage?

You should use non-stock scriplet resources to accept these bars (create cookies / click in Jeg forstår). If you do not use fixed IDCAC addon.

It doesn't always help to have a script:

  • aopr
  • aopw
  • acis
  • set
  • remove-cookie (message depending on the location detected))

that interrupts load bar.

https://github.com/uBlock-user/uBO-Scriptlets/blob/master/scriptlets.txt

cookie-set.js https://github.com/uBlock-user/uBO-Scriptlets/blob/527a210fadcb9608840aea4803b2684e4d18341e/scriptlets.txt#L225-L241

I don't know a publicly available click script compatible with uBO.

Yuki2718 commented 4 years ago

I occasionally come across such cookie warnings too.

I don't know a publicly available click script compatible with uBO.

Nano seems to have such a scriptlet https://raw.githubusercontent.com/NanoAdblocker/NanoFilters/master/NanoFilters/NanoResources.txt. I guess the reason gorhill doesn't adopt this kind may be security concern - such scriptlets can be abused by a bad filter author, while currently supported scriptlets at worst can break pages.

liamengland1 commented 4 years ago

For https://github.com/DandelionSprout/adfilt/issues/63#issuecomment-612523781: test ||agm.as/agent.js$3p

It works for me, but does it break anything?

krystian3w commented 4 years ago

Nano seems to have such a scriptlet

Nano scriplet need unlock for uBO - because have:

    var guard = '{{nano}}';
    if ( guard === '{{nano}}' ) {
        return;
    }
THEtomaso commented 4 years ago

agderposten.no,hallingdolen.no##div[class*="_isSimple_"][class*="_prompt_"]

||agm.as/agent.js$3p

Both of your soultions seems to work just fine. Thanks guys! :+1:

@kiboke: Perhaps you could add one of these rules to IDCAC?

gwarser commented 4 years ago

https://www.reddit.com/r/uBlockOrigin/comments/g1e6z6/viafreedk/

DandelionSprout commented 4 years ago

Testing with https://www.viafree.dk/programmer/livsstil/luksusfaelden/saeson-24/episode-3, I can not find any breakage, apart from how the video must be paused and unpaused once for the video feed to show up.

krystian3w commented 4 years ago

Maybe that strange pause is "Breakage"?

DandelionSprout commented 4 years ago

It may very well be. Or not. Who knows, considering that 95% of the posts on r/uBlockOrigin are just "Omgz I just ran into some kind of error somewhere help me plz", which reminds me of 60-year old ladies having problems with using Facebook again.

liamengland1 commented 4 years ago

I mean, it's a support forum, not a technical journal.

DandelionSprout commented 4 years ago

I may have very little experience with support forums, but those 95% of the posts just don't have much info that could help fix problems. At best they serve as a vague direction indicator of "The site may or may not have been changing some features in the past month or two".

DandelionSprout commented 4 years ago

In this particular instance, there's nothing in the thread at the time of writing that explains what the encountered problem actually is.

DandelionSprout commented 4 years ago

Doing my semi-traditional mooching off of Frellwit's entries for Viafree Sweden, it seems that at least one of his entries fix the one currently known issue, so I'll adapt and commit them to my list now.

From the apparent look of it, viafree.*##.vjs-playing:upward(1) ~ .no-autoplay-overlay will become my fix (It'll be converted to viafree.no,viafree.dk#?#*:-abp-has(:scope > .vjs-playing) ~ .no-autoplay-overlay in the ABP version; the AdGuard version won't receive the fix at all due to not even supporting :scope.).