{Bug} "Actually Legitimate URL Shortener Tool" not working as expected

[TheLegendaryPhoenix08]

Actually Legitimate URL Shortener Tool not working as expected while using it with uBO on FireFox.

Please see the attached image:

[TheLegendaryPhoenix08]

[iam-py-test]

FYI, "Dandelion Sprout's Annoyances List" includes Legit URL, so you do not need both. Also, please post the whole URL (like this `[url]`); it is hard to read a URL out of an image. Just looking at it, q is needed for the search query and removing client breaks search suggestions. ved is only removed in Chromium browsers for a reason I fail to remember.

You can add these two rules to your "My filters" tab and see if they break anything:

||google.*^$removeparam=ved
||google.*^$removeparam=client

Test URL

https://www.google.com/search?q=dandleion+sprout&hl=en&source=hp&ei=lcydY_bcMPHY5NoPzJ6_2A0&iflsig=AJiK0e8AAAAAY53apT5n0m2aB-CTi1YpNrGMhDmx3lbN&ved=0ahUKEwi2--KX6YD8AhVxLFkFHUzPD9sQ4dUDCAk&uact=5&oq=dandleion+sprout&gs_lcp=Cgdnd3Mtd2l6EAMyBwgAEIAEEA0yBwgAEIAEEA0yBwgAEIAEEA0yBwgAEIAEEA0yBggAEBYQHjIICAAQFhAeEAoyBggAEBYQHjIGCAAQFhAeMgYIABAWEB4yBggAEBYQHjoUCAAQ6gIQtAIQigMQtwMQ1AMQ5QI6FAguEOoCELQCEIoDELcDENQDEOUCOgQIABBDOgQILhBDOhEILhCABBCxAxCDARDHARDRAzoHCC4Q1AIQQzoHCAAQsQMQQzoICAAQgAQQsQM6CggAELEDEIMBEEM6CwguEIAEEMcBEK8BOgUIABCABDoKCC4QgAQQ1AIQCjoHCAAQgAQQCjoHCC4QgAQQCjoNCC4QgAQQsQMQgwEQCjoHCC4QgAQQDToGCAAQHhANOggIABAIEB4QDVDgC1irJGCiJmgCcAB4AIABxAKIAbcdkgEIMC42LjEwLjGYAQCgAQGwAQo&sclient=gws-wiz

[DandelionSprout]

I think client would be safe to block on desktop, but I've long been worried that adding it to the list could implausibly cause issues with making Google show the correct page version to users (as I know that there's at least 4 versions of Google: Standard desktop; Very old desktop; Chrome Android; Other phone browsers), although I've never actually tested it. And I see now that an old entry for it was commented out with (Breaks search-term suggestions).

ved has been known to cause truckloads of breakage, from what I can remember in a hurry.

[Nojuuu]

I think ved and probably some other parameters could be removed from specific paths, but not everywhere, and it probably would be better to apply to document only?

[Nojuuu]

https://github.com/AdguardTeam/AdguardFilters/issues/87920 https://github.com/AdguardTeam/AdguardFilters/commit/293a7d939039c76b0a24cbcfb7e326108442da4c

I can't reproduce any issues removing ved from ||google.*/search

ClearURLs removed it too:

[iam-py-test]

@AdishSagarawat please test this rule in your "my filters" tab and report back if it breaks anything:

||google.*/search$removeparam=ved

@Nojuuu thanks for sharing those links. I don't see any issues either on a test profile in Firefox, but maybe it's specific to certain browser configuration or version? (the OP is on Android, I'm on Windows, maybe that makes a difference)

[Nojuuu]

I think removing it from the /url? path might have been the problem there? Isn't that used for redirections or something?

Also ved filter in Legit URLs used to be like this: $removeparam=ved,domain=google.*, so that's probably why it had issues.

[iam-py-test]

I think removing it from the /url? path might have been the problem there? Isn't that used for redirections or something?

You are correct; it's used by Google Search and other Google services like Docs and Google calendar invites (I know the second one is true as I just got a calendar invite)

[krystian3w]

ved can by tested in https://en.wikipedia.org/wiki/Google_Programmable_Search_Engine

https://cse.google.com/cse?cx=partner-pub-8345364103968660%3Ahvaj9v-f27m&ie=utf-8&q=chrome&sb=#gsc.tab=0&gsc.q=chrome&gsc.page=1

Then don't help uBO:

! https://github.com/uBlockOrigin/uAssets/issues/7960
www.google.*##+js(set, rwt, noopFunc)

So recommended ||google.*/search$removeparam=ved corectly omit CSE and https://www.google.com/url?.

[DandelionSprout]

@AdishSagarawat Are you using Firefox or a non-Firefox browser? Because I'm not sure how I missed for 8 days that Legitimate URL Shortener has this section:

!#if env_chromium
||google.$removeparam=ved
@@||google.com/url?$removeparam=ved
(...)
!#endif

Edit: Oh, right, your OP screenshot strongly indicates you're using Firefox. That would make it tricker for me to do consistent non-hasty testing of ved removal, as I currently only use Firefox for Windows to bypass media streaming sites' anti-screenshot DRM.

[Nojuuu]

I use Firefox on PC and Android and haven't noticed any issues yet.

[TheLegendaryPhoenix08]

@iam-py-test This is what I did according to your suggestion, and here is the result:

[TheLegendaryPhoenix08]

@DandelionSprout I use Firefox on desktop.

P.S. - I think that we can also remove 'client' it will not cause any breakage.

[TheLegendaryPhoenix08]

@DandelionSprout , @iam-py-test any update on this issue?

[DandelionSprout]

We were waiting for feedback from you about whether the ved entry was truly safe, not the other way around.

[TheLegendaryPhoenix08]

@DandelionSprout According to my test , removing "ved" doesn't seems to break anything.

[DandelionSprout]

I suppose I can indeed try to remove ved in all browsers after all now. Give me 4min.