Closed Shutruk closed 1 year ago
adfilt
What do you mean by this? All the filters in adflit?
I'm not very knowledgeable about Brave, but it feels a bit odd that a filterlist would crash the browser. Have you tried disabling all custom filters and seeing if it persists?
How do the crashes occur? Is it just the tab that closes/crashes, or does the entire browser close?
@iam-py-test Sorry for not specifying the one I'm using! It's https://raw.githubusercontent.com/DandelionSprout/adfilt/master/ClearURLs%20for%20uBo/clear_urls_uboified.txt
@DandelionSprout
No matter how many tabs or windows are open, brave crashes completely and closes everything without any error or notification, when I disable this filter specifically, opening youtu.be links work as intended.
That makes a bit more sense (although the fact that a filterlist can crash the browser still feels like a browser bug). The "ClearURLs for uBo" is just the ClearURLs rules converted into a filterlist specially for uBlock Origin (and AdGuard). The conversion script is not flawless, the list will still have any issues from the ClearURLs list (which is known to break websites and gets very little maintenance), and was never designed for (or tested in) Brave's adblocker. I would not recommend use of this list. Oddly, I don't see any youtu.be rules in that list though, and only 4 fairly normal rules for youtube.com. I suspect that maybe one of the global rules (maybe a regex?) is applying to that URL and Brave doesn't like it (but that's just speculation). I will try to get a virtual machine setup with Brave and test some time this week
Brave added support for removeparam recently but not everything works yet, for example: https://github.com/brave/adblock-rust/issues/246 https://github.com/brave/adblock-rust/issues/245
Also could be related to this https://github.com/brave/adblock-rust/issues/248 ? If so, you'll need to wait for update.
Thank you @Nojuuu I don't have time to look into this, but that sounds likely @Shutruk the best solution is probably to disable the ClearURLs for uBo for now, and wait for the fix from Brave to be available
Thanks for the help, I will disable it then till a fix is available.
Fix should be available now: https://github.com/brave/brave-browser/releases/tag/v1.47.186
@Shutruk can you confirm that there are no issues on the fixed Brave version? If not, then I can install Brave on a VM and look into what ClearURLs for uBo is doing wrong
@iam-py-test no more crashes happened after 1.47.186, the issue seems to be fixed.
Describe the problem below this line as meticulously and detailed as possible (incl. pagelinks if any)
Every time I try to open a link that consists of the youtube short version "youtu.be". brave crashes.
Add screenshots below if needed
No response
Add a screenshot of the extension's logger
No response
Which adblocker(s) did you use when testing this?
Brave's built-in adblocker
Adblocker version(s)
No response
Which filterlists did you use? Failing to tell this will temporarily close the report until it has been told.
CJX Easylist-Cookie Fanboy Annoyances Fanboy's Mobile Notifications ublock annoyances AdguardFilters adfilt
Which browser(s) did you use when testing this?
Brave Browser
Browser version(s)
1.47.171 Chromium: 109.0.5414.87 (64 bits)
Which OS(s) did you use when testing this?
Windows 11, macOS
OS version(s)
No response