DandelionSprout / adfilt

The place where I, DandelionSprout, store my web filter lists for countless topics, including my Nordic adblock list. As simple as that, really.
Other
1.3k stars 143 forks source link

Dandelion Sprout's Annoyances List (URL SHORTNER) Not working fully on Amazon #767

Closed TheLegendaryPhoenix08 closed 1 year ago

TheLegendaryPhoenix08 commented 1 year ago

Not removing s?rrh%n...

image

TheLegendaryPhoenix08 commented 1 year ago

See image

TheLegendaryPhoenix08 commented 1 year ago

Same on flipkart image

iam-py-test commented 1 year ago

See image

/ref can not be removed.

Please post links instead of images. Reading URLs out of images is difficult.

TheLegendaryPhoenix08 commented 1 year ago

Ohh Sorry

iam-py-test commented 1 year ago

Can you post the links?

DandelionSprout commented 1 year ago

I can see the links well enough (though they're very tricky to write manually), so essentially it's a matter of whether it's safe to remove rh and sbo from Amazon, and sid from Flipkart.

DandelionSprout commented 1 year ago

On https://www.amazon.in/Headphones-Sony-Earbuds-Accessories/s?rh=n%3A1388921031%2Cp_89%3ASony, rh can't be removed at all, as it seems to cause the page to redirect to the Amazon home page instead.

On https://www.amazon.in/Sony-WI-XB400-Wireless-Bluetooth-Headphones/dp/B07WNXS613/ref=sr_1_4_mod_primary_new?sbo=RZvfv%2F%2FHxDF%2BO5021pAnSA%3D%3D, it seems safe to remove sbo from what I can currently tell.

While on https://www.flipkart.com/audio-video/headset/sony~brand/pr?sid=0pm%2Cfcn, removing sid causes an error page.

TheLegendaryPhoenix08 commented 1 year ago

So, Will @DandelionSprout add a rule to remove sbo, or I have to do it manually?

TheLegendaryPhoenix08 commented 1 year ago

Also, I think that removing ref also will not cause any breakage.

iam-py-test commented 1 year ago

Will @DandelionSprout add a rule to remove sbo, or I have to do it manually?

sbo is removed from Amazon (https://github.com/DandelionSprout/adfilt/blob/master/LegitimateURLShortener.txt#L1623). Please update your lists.

Also, I think that removing ref also will not cause any breakage.

Do you mean /ref=sr_1_4_mod_primary_new from https://www.amazon.in/Sony-WI-XB400-Wireless-Bluetooth-Headphones/dp/B07WNXS613/ref=sr_1_4_mod_primary_new?sbo=RZvfv%2F%2FHxDF%2BO5021pAnSA%3D%3D? If so, then uBlock Origin (and by extension Legit URL) can not remove it. We can only remove query parameters (the stuff after the ?)