DandelionSprout / adfilt

The place where I, DandelionSprout, store my web filter lists for countless topics, including my Nordic adblock list. As simple as that, really.
Other
1.3k stars 143 forks source link

Update LegitimateURLShortener.txt #862

Closed Nojuuu closed 11 months ago

Nojuuu commented 12 months ago

Remove sa parameter. Adguard's list already removes it from /search path, but I added more paths that I think should be ok, and also limited it to just the document to play it safe.

Example urls:

Something like ||google.$document,removeparam=/^sa=X$/ could also work, but I don't have time to test everywhere, the only problem I know with removing this parameter is that if you remove it from /url? path but that path also has issues if you remove other params like ved.


Maybe old documentation, but might give some idea of what it is for:

https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#sa

DandelionSprout commented 12 months ago

I'm tempted to add something like simply ||google.$removeparam=/^sa=X$/, especially since I see that the parameter's removal doesn't seem to spell any immediate problems with image searches. I'll see when I have time to handle that.

iam-py-test commented 12 months ago

It does have other values, i.e. https://www.google.com/search?q=actually+legitimate+url+shortener+tool&tbm=vid&ei=zGVqZLfGCu2aptQPjdOV2AM&start=10&sa=N&ved=2ahUKEwi33Lr-h4f_AhVtjYkEHY1pBTsQ8tMDegQIExAE&biw=1280&bih=675&dpr=1.5

Nojuuu commented 12 months ago

If /url? has issues with any parameter removed maybe it needs @@||google.*/url?$removeparam ?

Nojuuu commented 12 months ago

@iam-py-test Where did you find sa=N? Also links in /finance "Today's financial news" have /url?sa=j and removing that causes that redirect error too so if there is /url?sa=X links hidden somewhere, people will probably complain about breakages, but I couldn't find any.

iam-py-test commented 12 months ago

I think from clicking on videos

DandelionSprout commented 12 months ago

I got sa=N when I clicked to get to page 2 or 3 or such on Google text search results.

Nojuuu commented 12 months ago

I got sa=N when I clicked to get to page 2 or 3 or such on Google text search results.

Ok, now I see it too.

Nojuuu commented 11 months ago

@DandelionSprout I suppose we could also try adding filter for sa=N, as there have been no reports of problems with sa=X in the first week?

DandelionSprout commented 11 months ago

I suppose so.