DandelionSprout / adfilt

The place where I, DandelionSprout, store my web filter lists for countless topics, including my Nordic adblock list. As simple as that, really.
Other
1.3k stars 143 forks source link

Unblock TV 2 assets, and block just ads script #87

Closed and-poulsen closed 3 years ago

and-poulsen commented 3 years ago

tv2a.dk is "TV 2 Assets", and not "TV 2 Ads" It includes functional scripts (web.tv2a.dk), fonts (fonts.tv2a.dk), and also our GDPR compliance enabler scripts (https://scripts.tv2a.dk/oil.eHJf.js etc.)

Our ads script is at https://scripts.tv2a.dk/ads/tv2ads.js (And might in the future be at the root of the domain), and another at https://scripts.tv2a.dk/prebid/prebid.js

The current rules causes serious degradation of our site.

At the time of when this rule was introduced (#49) , we didn't use this domain for much - but since then, we've added much more to it.

Disclaimer: I'm a developer at TV 2, for tv2.dk

DandelionSprout commented 3 years ago

This is the first time I've had a website's owner reach out to me about their site being blocked, so I've always been uncertain how to handle such requests. But I see that your request is a pretty fair one, so I'll choose to accept it pretty much as-is (except for some changes to whitelistings of individual tv2a.dk files and to the use of !+ NOT_OPTIMIZED). Give me 5min.

Around half an hour after I initially wrote this comment, I see now that you managed to dig up the exact issue report and tech enthusiast who suggested for me to block tv2a.dk, especially since the enthusiast wasn't exactly much of a fan of tracking (which I on the other hand is far more lenient on), ads, or even TV2 Danmark in general.

DandelionSprout commented 3 years ago

A different (and from what I'm aware of, American) enthusiast entirely also recommended to me at #88 that I could simply the suggested entries furthermore, which I accepted for the time being.

THEtomaso commented 3 years ago

tv2.dk freezes now (GDPR issue), because of the following rule, found in AdGuard Annoyances filter (@BlazDT): ##.as-oil ..and this rule, found in EasyList Cookie List / Fanboy's Annoyance List (@Khrin): ##.as-oil-content-overlay

Adding these additional blocking rules fixes the problem!:

tv2a.dk/oil.*$script,stylesheet
tv2a.dk/consent/
DandelionSprout commented 3 years ago

I Don't Care About Cookies, which is the cookie-banner-remover I'd recommend in almost all cases, thankfully seem to be unaffected by any such freezes. I'll submit those entries to its maintainer nevertheless, even if they only apply to the IDCAC filterlist and not the extension.

THEtomaso commented 3 years ago

I've edited my previous post, notifying filter maintainers.

THEtomaso commented 3 years ago

the cookie-banner-remover I'd recommend in almost all cases

IDCAC only blocks cookie consents though, while the annoyances filters that I mentioned removes a wide range of crap. But yes, considering the disregard for issue reports, I can't really recommend those latter ones.

BlazDT commented 3 years ago

Added to AdGuard Annoyances filter (video I tested still worked fine): ||scripts.tv2a.dk/oil-sdk^

and-poulsen commented 3 years ago

Thanks for responding and accepting the changes! @DandelionSprout

A different (and from what I'm aware of, American) enthusiast entirely also recommended to me at #88 that I could simply the suggested entries furthermore, which I accepted for the time being.

The issue with #88 is that we intent within 30 days to change the location of the script to the root of the domain (scripts.tv2a.dk/tv2ads.js and /prebid.js)

That's what I meant when I said:

Our ads script is at https://scripts.tv2a.dk/ads/tv2ads.js (And might in the future be at the root of the domain), and another at https://scripts.tv2a.dk/prebid/prebid.js

So can we make the changes either like in this PR, or something else that will target both placements?

THEtomaso commented 3 years ago
||tv2a.dk*/prebid.js
||tv2a.dk*/tv2ads.js

?

DandelionSprout commented 3 years ago

I can attempt some changes myself.

In most cases, EasyList already has an entry to block filenames containing /prebid., so that gives me one less thing I need to handle.

Thanks to my experiences with a completely different and much less popular list, I know that * can also be used to select no text at all, as THEtomaso is suggesting. Though I think I have a different idea in mind, now that I think about it. Give me 3min.

and-poulsen commented 3 years ago

Thanks a lot!