search

DandelionSprout / adfilt

The place where I, DandelionSprout, store my web filter lists for countless topics, including my Nordic adblock list. As simple as that, really.
Other
1.29k stars 141 forks source link

Reddit loads indefinitely when using Actually Legitimate URL Shortener Tool #985

Closed crisp5 closed 3 months ago

crisp5 commented 4 months ago

Describe the problem below this line as meticulously and detailed as possible (incl. pagelinks if any)

Upon opening https://reddit.com/ on Brave Android using the filter lists listed below, the site loads indefinitely. I've tracked the issue down to Actually Legitimate URL Shortener Tool, which I had added to Brave's Custom filter lists.

A very similar issue had been reported in the Brave forums earlier in 2023, and fixed with this pull request. Is this something that can also be applied here?

Add screenshots below if needed

No response

Add a screenshot of the extension's logger

No response

Which adblocker(s) did you use when testing this?

Brave's built-in adblocker (a.k.a. Brave Shield)

Adblocker version(s)

No response

Which filterlists did you use? Failing to tell this will temporarily close the report until it has been told.

Which browser(s) did you use when testing this?

Brave Browser

Browser version(s)

1.61.109

Which OS(s) did you use when testing this?

Android

OS version(s)

Android 14

DandelionSprout commented 4 months ago

Brave Shield is an adblocker I have rather limited experience with, but I'll look into it eventually. Hoping to do it within 48 hours, could be far quicker, could be slightly longer.

iam-py-test commented 4 months ago

I have temporarily disabled rdt based on the Brave forums post, but I do not know if that is the cause. In May of last year I added a warning that Brave's removeparam implementation was buggy, but the commit is vague and lacks reference to an issue or specific problem. Thanks

DandelionSprout commented 3 months ago

So, testing with Windows Subsystem for Android, hoping it'd be easier to test that way than on my physical phone (Kinda turned out it wasn't; turned out I had to set Vulkan rendering to off to get pages to load), I at least see that Legitimate URL Shortener is not included as opt-in or opt-out in Brave Shield. So that thankfully rules out the possibility that they could've included a list that was not designed for most Brave builds' Brave Shield.

I know all too well about how Reddit would go through the often many rdt redirects, but would proceed to load the actual subreddit after 2sec. However, I can't seem to reproduce those redirects on Brave Android nor Chrome Windows tonight.

Should they appear again, re-adding the rdt entry to the list but wrapping it in !#if cap_user_stylesheet should work, as Brave has a history of generally ignoring !#if tags.

crisp5 commented 3 months ago

OK FINALLY, my browser got into a weird state where custom filter lists were flat-out ignored, reinstalling took care of it. Can confirm that the last commit fixed the issue.

I at least see that Legitimate URL Shortener is not included as opt-in or opt-out in Brave Shield. So that thankfully rules out the possibility that they could've included a list that was not designed for most Brave builds' Brave Shield.

Yeah, it's definitely not included by them, but a recent-ish version of Brave Android made adding custom filter lists more prominent (Settings > Brave Shields > Content Filtering as opposed to through brave://adblock), so it's possible more users start delving into the world of filter lists. If that's the case, I'll leave this for future reference. Exceptions and regex aren't supported by removeparam yet, and some params are cleaned by the browser itself, independent of any removeparam rules.

Thanks y'all šŸ‘ Feel free to close unless there's any additional testing you want to do