DandyDeveloper / charts

Various helm charts migrated from [helm/stable] due to deprecation
https://dandydeveloper.github.io/charts
Apache License 2.0
157 stars 145 forks source link

[chart/redis-ha][BUG] checksum/init-config should include sentinel.conf as well #147

Closed zerkms closed 2 years ago

zerkms commented 3 years ago

Describe the bug It's defined as checksum/init-config: {{ print (include "config-redis.conf" .) (include "config-init.sh" .) (include "redis_liveness.sh" .) (include "redis_readiness.sh" .) (include "sentinel_liveness.sh" .) | sha256sum }}

So if you simply change something in the sentinel config - it won't trigger redeploy

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Additional context Add any other context about the problem here.

ArcticSnowman commented 2 years ago

OK so I don't need to create a issue for this... But maybe I can throw in a PR.